From 0f8d35f5166a6d91b39c2abb403716ec4a588fe3 Mon Sep 17 00:00:00 2001 From: Matysh Date: Fri, 14 Aug 2026 19:50:47 +0300 Subject: [PATCH] docs: run the AC-named smokes locally before S7-code-review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The owner's machine now carries Playwright with Chromium on Windows and a full WSL environment — verified by execution: 34/34 smoke assertions, and 242 backend tests passed where native Windows silently skips every test_ha_* file. A red smoke that reaches the review costs a cycle of forty-five minutes plus the return trip; run locally it costs a minute, and #89 already paid that price once. WSL runs of the full harness and golden verify are advisory. The canon does not move: the beta gate is CI at the exact SHA, and baselines are accepted only via golden:accept --reviewed on a complete Linux CI artefact. Issue: #151 User-Visible: no --- AGENTS.md | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 4ec8b8aa..08ef04b9 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -320,9 +320,19 @@ cp dist/houseplan-card.js custom_components/houseplan/frontend/houseplan-card.js cp dist/houseplan-card.js demo/srv/assets/houseplan-card.js ``` -During the implementation cycle only the fast gates run. `smoke`, `golden` and -`performance_smoke` spin up Chromium and belong to the pre-beta run — which is then -mandatory and complete. +During the implementation cycle the fast gates always run. Since 2026-08-14 the +owner's machine also carries Playwright with Chromium (Windows) and a full WSL +environment, which changes one thing (#151): **before moving an issue to +`S7-code-review`, run the smokes named in its AC locally** — `node +demo/smoke_.mjs`. A red smoke that reaches the review costs a cycle; run +locally it costs a minute. Precedent: on #89 a fixture error lived through a +whole review round that a local run would have caught immediately. + +The full smoke set, `golden` and `performance_smoke` still belong to the +pre-beta run — which is then mandatory and complete. WSL runs of the full HA +harness (`~/houseplan-card`, venv) and `golden:verify` are advisory; **the canon +does not move**: the beta gate is CI at the exact SHA, and baselines are accepted +only via `npm run golden:accept -- --reviewed` on a complete Linux CI artefact. **Backend.** A full Home Assistant harness cannot run on native Windows at all: Home Assistant imports the Unix-only `fcntl` module. Its canon is Linux CI or WSL.