mirror of
https://github.com/Matysh/houseplan-card
synced 2026-10-03 13:18:58 +00:00
ci: reviewed run судится только release-потребителем (#573, ревью r1 M1)
`loadGithubProofContext` спрашивал объявленный `Baseline-Reviewed` run для любого потребителя, а `evaluateCiProof` судил его при `reviewedRun: null` — merge и review начинали зависеть от доступности старого run по чужой причине. Теперь запрос делается только с `withReviewedRun` (release-gate передаёт его вместе с ожиданиями), а проверка стоит внутри `if (expected)` — рядом со сверкой evidence, где ей и место. Тест: без ожиданий merge/review green при reviewedRun undefined/null/пустом; фейковый fetch доказывает, что запроса нет. Issue: #573 User-Visible: no
This commit is contained in:
+3
-1
@@ -501,7 +501,9 @@ executed or reused. Release consumers standing on the candidate checkout
|
||||
(`release-gate.mjs`, `release-prerelease.mjs`) recompute all of it locally and
|
||||
fail closed on any mismatch, on a reused marker whose key is not the
|
||||
candidate's, and on a declared review run that does not exist, was cancelled
|
||||
or is not a Validate run; a proof without the block is stale for them. The
|
||||
or is not a Validate run; a proof without the block is stale for them. Review
|
||||
and merge consumers pass no expectations, do not query the declared review run
|
||||
and keep the #541 semantics unchanged. The
|
||||
practical consequence is the beta.3 path: a candidate red only in golden,
|
||||
then a baseline-only commit that reuses smoke, performance smoke, parity and
|
||||
backend from the candidate's green jobs, skips every caught witness in the
|
||||
|
||||
Reference in New Issue
Block a user