german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-01 04:09:17 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix: match wall thickness hover to masonry

Browse Source 
Issue: #303
User-Visible: yes
This commit is contained in:
Matysh
2026-08-25 12:49:41 +03:00
parent 0f71d869e3
commit 36992d68bd
10 changed files with 205 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/grid-scale.test.mjs
+29
View File
@@ -8,8 +8,11 @@ import {
gridVisualScale,
gridVisualUnits,
newSpaceCellCm,
wallThickHoverHalfUnits,
} from '../test-build/grid-scale.js';
const GRID_PITCH = 1000 / 240;
test('visual scale preserves the 5 cm reference and follows physical equivalence', () => {
assert.equal(GRID_VISUAL_REFERENCE_CELL_CM, 5);
assert.equal(gridVisualScale(5), 1);
@@ -25,6 +28,32 @@ test('invalid visual-scale inputs retain the legacy 5 cm appearance', () => {
}
});
test('wall-thickness hover uses the exact physical wall width at every cell scale (#303)', () => {
assert.equal(wallThickHoverHalfUnits(50, 30, GRID_PITCH), (50 / 30) * GRID_PITCH / 2);
assert.equal(wallThickHoverHalfUnits(12.5, 5, GRID_PITCH), GRID_PITCH * 1.25);
assert.equal(wallThickHoverHalfUnits(3, 5, GRID_PITCH) * 2, 2.5);
});
test('zero-thickness hover keeps the reference look and one physical width (#303)', () => {
const atFive = wallThickHoverHalfUnits(0, 5, GRID_PITCH);
const atThirty = wallThickHoverHalfUnits(0, 30, GRID_PITCH);
assert.equal(atFive * 2, GRID_PITCH * 3);
assert.equal((atFive * 2 / GRID_PITCH) * 5, 15);
assert.ok(Math.abs((atThirty * 2 / GRID_PITCH) * 30 - 15) < 1e-12);
});
test('wall-thickness hover treats invalid thickness and cell size as safe fallbacks (#303)', () => {
const zero = wallThickHoverHalfUnits(0, 5, GRID_PITCH);
for (const cm of [-1, NaN, Infinity, -Infinity]) {
assert.equal(wallThickHoverHalfUnits(cm, 5, GRID_PITCH), zero);
}
for (const cellCm of [0, -1, NaN, Infinity, -Infinity]) {
assert.equal(wallThickHoverHalfUnits(0, cellCm, GRID_PITCH), zero);
}
assert.equal(wallThickHoverHalfUnits(50, 0, GRID_PITCH), 5 * GRID_PITCH);
assert.equal(wallThickHoverHalfUnits(50, 30, NaN), 0);
});
test('new-space defaults use one centimetre or exactly one inch', () => {
assert.equal(newSpaceCellCm(false), 1);
assert.equal(newSpaceCellCm(true), GRID_IMPERIAL_CELL_CM);