fix+test v1.13.2: audit round 3

- 12-test buildDevices suite on a fake hass (curation, markers, groups, dedup,
  icon rules, lock override, device_class fallback, primary/LQI/temp)
- t() substitutes all placeholder occurrences (pure subst() + regression test)
- _saveConfigNow resyncs config on rev conflict before rethrowing
- pointercancel clears the long-press timer (phantom info card on touch)
- repairs.py: plan-file check re-runs after every config save
- test build compiles devices.ts/types.ts; fix-test-build.mjs adds .js to ESM imports

custom_components/houseplan/__init__.py

@@ -7,7 +7,6 @@ from pathlib import Path
 from homeassistant.components.frontend import add_extra_js_url
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import ConfigEntryNotReady
-from homeassistant.helpers import issue_registry as ir
 
 from . import websocket_api as hp_ws
 from .const import (
@@ -19,6 +18,7 @@ from .const import (
     PLANS_URL,
     VERSION,
 )
+from .repairs import async_check_plan_files
 from .store import HouseplanConfigEntry, create_data
 
 _LOGGER = logging.getLogger(__name__)
@@ -82,47 +82,10 @@ async def async_setup_entry(hass: HomeAssistant, entry: HouseplanConfigEntry) ->
     if not await _register_lovelace_resource(hass, module_url):
         add_extra_js_url(hass, module_url)
 
-    await _check_plan_files(hass, entry)
+    await async_check_plan_files(hass, entry)
     return True
 
 
-async def _check_plan_files(hass: HomeAssistant, entry: HouseplanConfigEntry) -> None:
-    """Repairs: raise an issue for every space whose plan file is missing on disk."""
-    cfg_raw = await entry.runtime_data.config_store.async_load() or {}
-    spaces = cfg_raw.get("config", {}).get("spaces", [])
-    plans_dir = Path(hass.config.path(PLANS_DIR))
-
-    def _missing() -> list[tuple[str, str]]:
-        res = []
-        for sp in spaces:
-            url = sp.get("plan_url") or ""
-            if not url.startswith(PLANS_URL + "/"):
-                continue  # external/legacy URL — not ours to verify
-            fname = url[len(PLANS_URL) + 1 :].split("?", 1)[0]
-            if not (plans_dir / fname).is_file():
-                res.append((sp.get("id", "?"), fname))
-        return res
-
-    missing = await hass.async_add_executor_job(_missing)
-    seen = set()
-    for space_id, fname in missing:
-        seen.add(space_id)
-        ir.async_create_issue(
-            hass,
-            DOMAIN,
-            f"broken_plan_{space_id}",
-            is_fixable=False,
-            severity=ir.IssueSeverity.WARNING,
-            translation_key="broken_plan",
-            translation_placeholders={"space": space_id, "file": fname},
-        )
-    # clear stale issues for spaces that are fine again (or gone)
-    for sp in spaces:
-        sid = sp.get("id", "?")
-        if sid not in seen:
-            ir.async_delete_issue(hass, DOMAIN, f"broken_plan_{sid}")
-
-
 async def async_unload_entry(hass: HomeAssistant, entry: HouseplanConfigEntry) -> bool:
     """Unload the entry.
 

custom_components/houseplan/const.py

@@ -11,7 +11,7 @@ PLANS_DIR = "houseplan/plans"  # relative to the HA configuration directory
 FILES_URL = "/houseplan_files/files"
 FILES_DIR = "houseplan/files"
 CONF_ADMIN_ONLY = "admin_only"
-VERSION = "1.13.1"
+VERSION = "1.13.2"
 
 DEFAULT_CONFIG: dict = {
     "spaces": [],

custom_components/houseplan/manifest.json

@@ -16,5 +16,5 @@
   "issue_tracker": "https://github.com/Matysh/houseplan-card/issues",
   "requirements": [],
   "single_config_entry": true,
-  "version": "1.13.1"
+  "version": "1.13.2"
 }

custom_components/houseplan/repairs.py

@@ -0,0 +1,52 @@
+"""Repair issues for House Plan.
+
+The check runs at entry setup AND after every config save (ws_config_set),
+so a plan file that goes missing — or gets re-uploaded — is reflected in the
+Repairs UI without waiting for a restart.
+"""
+from __future__ import annotations
+
+from pathlib import Path
+
+from homeassistant.core import HomeAssistant
+from homeassistant.helpers import issue_registry as ir
+
+from .const import DOMAIN, PLANS_DIR, PLANS_URL
+from .store import HouseplanConfigEntry
+
+
+async def async_check_plan_files(hass: HomeAssistant, entry: HouseplanConfigEntry) -> None:
+    """Raise an issue for every space whose plan file is missing on disk."""
+    cfg_raw = await entry.runtime_data.config_store.async_load() or {}
+    spaces = cfg_raw.get("config", {}).get("spaces", [])
+    plans_dir = Path(hass.config.path(PLANS_DIR))
+
+    def _missing() -> list[tuple[str, str]]:
+        res = []
+        for sp in spaces:
+            url = sp.get("plan_url") or ""
+            if not url.startswith(PLANS_URL + "/"):
+                continue  # external/legacy URL — not ours to verify
+            fname = url[len(PLANS_URL) + 1 :].split("?", 1)[0]
+            if not (plans_dir / fname).is_file():
+                res.append((sp.get("id", "?"), fname))
+        return res
+
+    missing = await hass.async_add_executor_job(_missing)
+    broken = set()
+    for space_id, fname in missing:
+        broken.add(space_id)
+        ir.async_create_issue(
+            hass,
+            DOMAIN,
+            f"broken_plan_{space_id}",
+            is_fixable=False,
+            severity=ir.IssueSeverity.WARNING,
+            translation_key="broken_plan",
+            translation_placeholders={"space": space_id, "file": fname},
+        )
+    # clear stale issues for spaces that are fine again (or gone)
+    for sp in spaces:
+        sid = sp.get("id", "?")
+        if sid not in broken:
+            ir.async_delete_issue(hass, DOMAIN, f"broken_plan_{sid}")

custom_components/houseplan/websocket_api.py

@@ -180,6 +180,12 @@ async def ws_config_set(hass: HomeAssistant, connection, msg: dict[str, Any]) ->
         new_rev = current_rev + 1
         await rt.config_store.async_save({"config": msg["config"], "rev": new_rev})
     hass.bus.async_fire("houseplan_config_updated", {"rev": new_rev})
+    # refresh repair issues (broken plan references) without waiting for a restart
+    entry = get_entry(hass)
+    if entry is not None:
+        from .repairs import async_check_plan_files
+
+        hass.async_create_task(async_check_plan_files(hass, entry))
     connection.send_result(msg["id"], {"ok": True, "rev": new_rev})