mirror of
https://github.com/Matysh/houseplan-card
synced 2026-07-31 08:28:31 +00:00
fix+test v1.13.2: audit round 3
- 12-test buildDevices suite on a fake hass (curation, markers, groups, dedup, icon rules, lock override, device_class fallback, primary/LQI/temp) - t() substitutes all placeholder occurrences (pure subst() + regression test) - _saveConfigNow resyncs config on rev conflict before rethrowing - pointercancel clears the long-press timer (phantom info card on touch) - repairs.py: plan-file check re-runs after every config save - test build compiles devices.ts/types.ts; fix-test-build.mjs adds .js to ESM imports
This commit is contained in:
Matysh
@@ -0,0 +1,160 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { buildDevices, lightGroups, primaryEntity, lqiFor, tempFor } from '../test-build/devices.js';
|
||||
import { compileIconRules } from '../test-build/rules.js';
|
||||
|
||||
/** Minimal fake hass around the pieces buildDevices reads. */
|
||||
function mkHass({ devices = {}, entities = {}, states = {}, areas = {} } = {}) {
|
||||
return { devices, entities, states, areas };
|
||||
}
|
||||
const loc = (k) =>
|
||||
({ 'device.unnamed': 'unnamed', 'device.light_group': 'light group',
|
||||
'device.fallback': 'device', 'device.virtual': 'virtual device' }[k]);
|
||||
const baseCtx = (hass, over = {}) => ({
|
||||
hass, areaToSpace: { living: 'f1', kitchen: 'f1' }, markers: [], settings: {},
|
||||
excluded: new Set(['hacs']), showAll: false, firstSpaceId: 'f1', loc, ...over,
|
||||
});
|
||||
const dev = (id, name, model, area, extra = {}) =>
|
||||
({ id, name, model, area_id: area, identifiers: [['demo', id]], entry_type: null, via_device_id: null, ...extra });
|
||||
|
||||
test('buildDevices: devices outside bound areas are dropped', () => {
|
||||
const h = mkHass({ devices: {
|
||||
a: dev('a', 'Lamp', 'Bulb', 'living'),
|
||||
b: dev('b', 'Lamp', 'Bulb', 'garage'), // area not bound to a room
|
||||
c: dev('c', 'Lamp', 'Bulb', null), // no area at all
|
||||
}});
|
||||
const res = buildDevices(baseCtx(h));
|
||||
assert.deepEqual(res.map((d) => d.id), ['a']);
|
||||
assert.equal(res[0].space, 'f1');
|
||||
});
|
||||
|
||||
test('buildDevices: curation hides excluded/service/group/scene/bridge, show_all reveals', () => {
|
||||
const h = mkHass({ devices: {
|
||||
ok: dev('ok', 'Plug', 'Smart Plug', 'living'),
|
||||
ex: dev('ex', 'HACS', 'x', 'living', { identifiers: [['hacs', '1']] }),
|
||||
sv: dev('sv', 'Service', 'x', 'living', { entry_type: 'service' }),
|
||||
gr: dev('gr', 'Group dev', 'Group', 'living'),
|
||||
sc: dev('sc', 'Scenes', 'wireless scene switch', 'living'),
|
||||
br: dev('br', 'Zigbee Bridge', 'Bridge V2', 'living'),
|
||||
}});
|
||||
assert.deepEqual(buildDevices(baseCtx(h)).map((d) => d.id), ['ok']);
|
||||
// show_all reveals everything except service entries (those are never devices on the plan)
|
||||
const all = buildDevices(baseCtx(h, { showAll: true })).map((d) => d.id);
|
||||
assert.deepEqual(all.sort(), ['br', 'ex', 'gr', 'ok', 'sc']);
|
||||
});
|
||||
|
||||
test('buildDevices: duplicate name|area gets numbered, different areas do not', () => {
|
||||
const h = mkHass({ devices: {
|
||||
a: dev('a', 'Lamp', 'Bulb', 'living'),
|
||||
b: dev('b', 'Lamp', 'Bulb', 'living'),
|
||||
c: dev('c', 'Lamp', 'Bulb', 'kitchen'),
|
||||
}});
|
||||
const names = buildDevices(baseCtx(h)).map((d) => d.name);
|
||||
assert.deepEqual(names, ['Lamp', 'Lamp 2', 'Lamp']);
|
||||
});
|
||||
|
||||
test('buildDevices: light groups appear, single lamps in grouped areas are suppressed', () => {
|
||||
const h = mkHass({
|
||||
devices: { lamp: dev('lamp', 'Ceiling lamp', 'Bulb E27', 'living') },
|
||||
entities: {
|
||||
'light.group_living': { entity_id: 'light.group_living', platform: 'group', area_id: 'living' },
|
||||
'light.single': { entity_id: 'light.single', device_id: 'lamp', platform: 'demo' },
|
||||
},
|
||||
states: { 'light.group_living': { state: 'on', attributes: { friendly_name: 'Living lights' } } },
|
||||
});
|
||||
const res = buildDevices(baseCtx(h));
|
||||
const ids = res.map((d) => d.id);
|
||||
assert.ok(ids.includes('lg_light.group_living'));
|
||||
assert.ok(!ids.includes('lamp'), 'single lamp must fold into the group');
|
||||
// group_lights=false: no groups, the lamp comes back
|
||||
const res2 = buildDevices(baseCtx(h, { settings: { group_lights: false } }));
|
||||
assert.deepEqual(res2.map((d) => d.id), ['lamp']);
|
||||
});
|
||||
|
||||
test('buildDevices: claimed device is replaced by its marker (metadata applied)', () => {
|
||||
const h = mkHass({ devices: { a: dev('a', 'Boiler', 'BAXI', 'living') } });
|
||||
const markers = [{ id: 'a', binding: 'device:a', name: 'Main boiler', icon: 'mdi:water-boiler',
|
||||
link: 'https://x', tap_action: 'more-info' }];
|
||||
const res = buildDevices(baseCtx(h, { markers }));
|
||||
assert.equal(res.length, 1);
|
||||
const it = res[0];
|
||||
assert.equal(it.name, 'Main boiler');
|
||||
assert.equal(it.icon, 'mdi:water-boiler');
|
||||
assert.equal(it.link, 'https://x');
|
||||
assert.equal(it.tapAction, 'more-info');
|
||||
assert.equal(it.bindingKind, 'device');
|
||||
});
|
||||
|
||||
test('buildDevices: hidden marker removes the device entirely', () => {
|
||||
const h = mkHass({ devices: { a: dev('a', 'Noisy', 'x', 'living') } });
|
||||
const res = buildDevices(baseCtx(h, { markers: [{ id: 'a', binding: 'device:a', hidden: true }] }));
|
||||
assert.equal(res.length, 0);
|
||||
});
|
||||
|
||||
test('buildDevices: virtual marker lands in its room; entity marker resolves name from state', () => {
|
||||
const h = mkHass({
|
||||
entities: { 'sensor.avg': { entity_id: 'sensor.avg', platform: 'min_max', area_id: 'kitchen' } },
|
||||
states: { 'sensor.avg': { state: '21', attributes: { friendly_name: 'Average temp' } } },
|
||||
});
|
||||
const markers = [
|
||||
{ id: 'v1', binding: 'virtual', name: 'Septic tank', icon: 'mdi:pipe', space: 'f1', area: 'living' },
|
||||
{ id: 'lg_sensor.avg', binding: 'entity:sensor.avg' },
|
||||
];
|
||||
const res = buildDevices(baseCtx(h, { markers }));
|
||||
const v = res.find((d) => d.id === 'v1');
|
||||
assert.ok(v.virtual);
|
||||
assert.equal(v.icon, 'mdi:pipe');
|
||||
const e = res.find((d) => d.id === 'lg_sensor.avg');
|
||||
assert.equal(e.name, 'Average temp');
|
||||
assert.equal(e.primary, 'sensor.avg');
|
||||
assert.equal(e.space, 'f1'); // via the entity's area
|
||||
});
|
||||
|
||||
test('buildDevices: custom icon rules apply; lock entity still forces mdi:lock', () => {
|
||||
const h = mkHass({
|
||||
devices: {
|
||||
p: dev('p', 'Steckdose Küche', 'Plug S26', 'living'),
|
||||
l: dev('l', 'Home', 'S2', 'living'),
|
||||
},
|
||||
entities: { 'lock.front': { entity_id: 'lock.front', device_id: 'l', platform: 'demo' } },
|
||||
});
|
||||
const iconRules = compileIconRules([{ pattern: 'steckdose', icon: 'mdi:power-socket-eu' }]);
|
||||
const res = buildDevices(baseCtx(h, { iconRules }));
|
||||
assert.equal(res.find((d) => d.id === 'p').icon, 'mdi:power-socket-eu');
|
||||
assert.equal(res.find((d) => d.id === 'l').icon, 'mdi:lock');
|
||||
});
|
||||
|
||||
test('buildDevices: device_class fallback when no rule matches', () => {
|
||||
const h = mkHass({
|
||||
devices: { t: dev('t', 'XYZZY-42', 'unknown', 'living') },
|
||||
entities: { 'sensor.x': { entity_id: 'sensor.x', device_id: 't', platform: 'demo' } },
|
||||
states: { 'sensor.x': { state: '21.5', attributes: { device_class: 'temperature', unit_of_measurement: '°C' } } },
|
||||
});
|
||||
const it = buildDevices(baseCtx(h))[0];
|
||||
assert.equal(it.icon, 'mdi:thermometer');
|
||||
assert.equal(it.temp, 21.5);
|
||||
assert.equal(it.primary, 'sensor.x');
|
||||
});
|
||||
|
||||
test('primaryEntity: domain priority and diagnostic-category demotion', () => {
|
||||
const h = mkHass({
|
||||
entities: {
|
||||
'sensor.batt': { entity_id: 'sensor.batt', entity_category: 'diagnostic' },
|
||||
'light.a': { entity_id: 'light.a' },
|
||||
'sensor.temp': { entity_id: 'sensor.temp' },
|
||||
},
|
||||
states: {},
|
||||
});
|
||||
assert.equal(primaryEntity(h, ['sensor.batt', 'sensor.temp', 'light.a'], 'mdi:lightbulb'), 'light.a');
|
||||
// only a diagnostic entity → still usable as a last resort
|
||||
assert.equal(primaryEntity(h, ['sensor.batt'], 'mdi:chip'), 'sensor.batt');
|
||||
});
|
||||
|
||||
test('lqiFor: dedicated sensor wins over attribute duplication; tempFor rounds', () => {
|
||||
const h = mkHass({ states: {
|
||||
'sensor.x_linkquality': { state: '120', attributes: { unit_of_measurement: 'lqi' } },
|
||||
'sensor.temp': { state: '22.46', attributes: { device_class: 'temperature', linkquality: 118 } },
|
||||
}});
|
||||
assert.equal(lqiFor(h, ['sensor.x_linkquality', 'sensor.temp']), 119); // avg(120,118)
|
||||
assert.equal(tempFor(h, ['sensor.temp']), 22.5);
|
||||
});
|
||||
Reference in New Issue
Block a user