german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-02 12:49:56 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

fix(editor): a render no longer restarts a failed runtime load (#757)

Browse Source 
The lazy-runtime contract (#353) says a non-terminal failure waits for
the next explicit intent and that there are no background retries. But
_renderBody calls ensure() on every repaint while a surface waits for
the editor or onboarding runtime, and to the loader that call was
indistinguishable from an intent. Surfaces the core opens without the
runtime - the kiosk size dialog after a 3 s hold, the floor import
wizard on an empty plan, a dialog a warm remount revives - therefore
turned one failure into a loop: the loader's own state change, the
toast and its expiry, every hass tick repainted, started a new cycle
and showed a new toast every ~3.5 s. A wall tablet whose old hashed
chunks answer 404 after an integration update sat in that loop forever.

EditorRuntimeLoader.ensure takes an intent: the render calls it as
'reconcile'. A reconcile starts the first cycle a surface needs, but
after a non-terminal failure it returns false without loading until an
explicit ensure() - a tab, an opener, _requestMode, "Add space" - has
started a new cycle. Explicit calls, the terminal fingerprint failure,
ready and an in-flight cycle behave as before, for every loader
instance. The card's render lines stay line-neutral.

smoke_lazy_editor_chunk gains the three surfaces offline through their
real paths (a 3 s touch hold on a kiosk card, an empty plan pushed by
the server, General settings revived by a remount): one cycle, one
notice and an idle loader over 8 s, then the Plan tab and "Add space"
heal. On dev: 4 requests / 3 notices, 6 / 2 and 3 / 2. The loader unit
test pins reconcile versus intent; the mutant
render-reconcile-restarts-editor-runtime-cycle is guarded by the smoke.

Issue: #757
User-Visible: yes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018qZfe7YS4rqEMKoVeS3GKd
This commit is contained in:
Claude
2026-10-01 12:12:15 +00:00
committed by claude[bot]
parent b84465e541
commit 4091d83af3
8 changed files with 232 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/mutation-registry.mjs
+13
View File
@@ -13522,6 +13522,19 @@ const MUTANT_DEFINITIONS = [
replace: ' // mutant: the visible draft revives without its dirty baseline',
}],
},
{
id: 'render-reconcile-restarts-editor-runtime-cycle',
guard: 'node demo/smoke_lazy_editor_chunk.mjs',
because: '#757 AC1: _renderBody asks for the editor runtime on every repaint while a '
+ 'surface the core opened (kiosk size dialog, warm-revived dialog) waits for it; '
+ 'calling it as an intent turns one network failure into a new cycle and a new '
+ 'notice every few seconds — only the production card render shows this',
patches: [{
file: 'src/houseplan-card.ts',
find: " if (editorRuntimeRequested && !this._editorRuntime) void this._editorRuntimeLoader.ensure('reconcile');",
replace: ' if (editorRuntimeRequested && !this._editorRuntime) void this._editorRuntimeLoader.ensure(); // mutant: a render is an intent',
}],
},
{
id: 'marker-discard-without-asking',
guard: 'node demo/smoke_device_settings_form.mjs',