german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-07-31 16:38:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test: race the sweep against a save, not a reload against a save

Browse Source 
A reload has an unload window where any WS call answers not_ready, so the save
failed at random — and the vaguer assertion this test used to carry was exactly
what hid that. Driving data.sweep() directly is the concurrency the write lock
actually guards.
This commit is contained in:
Matysh
2026-07-28 21:13:45 +03:00
parent 9868f1035f
commit 8e07e3c958
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests_backend/test_ha_websocket.py
+8 -5
View File
@@ -991,11 +991,14 @@ async def test_sweep_and_a_config_write_do_not_race(
cfg2 = await _referenced_config() cfg2 = await _referenced_config()
cfg2["spaces"][0]["plan_url"] = "/api/houseplan/content/plans/_/s5.newcomer.png" cfg2["spaces"][0]["plan_url"] = "/api/houseplan/content/plans/_/s5.newcomer.png"
entry = hass.config_entries.async_entries(DOMAIN)[0] # Drive the sweep directly rather than through a reload: an entry reload has
_reload, saved = await asyncio.gather( # an unload window in which any WS call legitimately answers `not_ready`, so
hass.config_entries.async_reload(entry.entry_id), # runs the sweep # a save racing THAT proves nothing about the lock and fails at random.
_save(client, cfg2, rev), from custom_components.houseplan.store import get_data
)
data = get_data(hass)
assert data is not None and data.sweep is not None
_swept, saved = await asyncio.gather(data.sweep(), _save(client, cfg2, rev))
await hass.async_block_till_done() await hass.async_block_till_done()
# assert the CONCRETE outcome: a save that came back `not_ready` would leave # assert the CONCRETE outcome: a save that came back `not_ready` would leave