german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-04 21:58:56 +00:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

fix: make the handle paint order a named decision and mutate it (#400)

Browse Source 
CODE-REVIEW-400-r1 Medium: the registered mutant edited a comment, not
the order — it could not reproduce the regression AC1 exists to catch.
That is the same defect class this issue is fixing elsewhere, in my own
guard.

The order is now HANDLE_PAINT_ORDER, a named constant, because it IS the
hit priority rather than an accident of where the blocks sit in the
template. The mutant flips that constant, so it reproduces exactly the
behaviour the audit found.

Also: smoke_furniture picked the SE corner as handles[3], an index that
silently depended on the old paint order — CI shard 3 went red on four
checks. It now selects by role (corner handles, third of four), which is
what the test actually means.

User-Visible: no
Issue: #400
This commit is contained in:
Codex
2026-08-31 08:14:55 +03:00
parent f07e3c54ff
commit d153b20a1d
3 changed files with 41 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/houseplan-card.ts
+26 -19
View File
@@ -811,6 +811,19 @@ interface DeviceInboxDialogState {
type FixedFloorState = FixedFloorSelection | { kind: 'pending'; value: unknown };
/**
* #400: the paint order of the selection handles IS the hit priority, so it is
* a named decision rather than a consequence of where the blocks happen to sit
* in the template.
*
* Corner and edge handles carry the same hit radius (1.8 % of the view). On
* furniture narrower than 4·hr — a 40 cm cabinet — their circles overlap, and
* whichever is painted last takes the tap. The corner must be last: an edge
* handle scales one axis, a corner scales both, and the object is small
* exactly when proportional resize matters most.
*/
const HANDLE_PAINT_ORDER = ['edges', 'corners'] as const;
interface DeviceDragState {
id: string;
spaceId: string;
@@ -8464,25 +8477,19 @@ export class HouseplanCard extends LitElement {
<circle class="dthandle dtrot" cx="${b.x + b.w / 2}" cy="${b.y - arm}" r="${hr.toFixed(1)}"
@pointerdown=${(e: PointerEvent) => this._dtStart(e, 'rotate')}></circle>
<circle class="dtknob" cx="${b.x + b.w / 2}" cy="${b.y - arm}" r="${kr.toFixed(2)}"></circle>
${sides.map(([sx, sy, cur]) => {
const x = sx < 0 ? b.x : sx > 0 ? b.x + b.w : b.x + b.w / 2;
const y = sy < 0 ? b.y : sy > 0 ? b.y + b.h : b.y + b.h / 2;
return svg`<circle class="dthandle dtedge dt-${cur}" cx="${x}" cy="${y}"
r="${hr.toFixed(1)}" @pointerdown=${(e: PointerEvent) =>
this._dtStart(e, 'scale', [sx, sy])}></circle>
<circle class="dtknob dtedgeknob" cx="${x}" cy="${y}" r="${kr.toFixed(2)}"></circle>`;
})}
${/* #400: corners LAST. Both handles carry the same hit radius (1.8 % of
the view), so on furniture narrower than 4·hr — a 40 cm cabinet — the
two circles overlap and whichever is painted later takes the hit.
The corner is the one that cannot be reached any other way: an edge
handle scales one axis, a corner scales both, and the object is small
precisely when proportional resize matters most. The bead order is
unchanged visually — the knobs are drawn with their own handles. */
corners.map(([sx, sy, cur]) => svg`<circle class="dthandle dt-${cur}"
cx="${sx < 0 ? b.x : b.x + b.w}" cy="${sy < 0 ? b.y : b.y + b.h}" r="${hr.toFixed(1)}"
@pointerdown=${(e: PointerEvent) => this._dtStart(e, 'scale', [sx, sy])}></circle><circle class="dtknob"
cx="${sx < 0 ? b.x : b.x + b.w}" cy="${sy < 0 ? b.y : b.y + b.h}" r="${kr.toFixed(2)}"></circle>`)}
${HANDLE_PAINT_ORDER.map((role) => (role === 'edges'
? sides.map(([sx, sy, cur]) => {
const x = sx < 0 ? b.x : sx > 0 ? b.x + b.w : b.x + b.w / 2;
const y = sy < 0 ? b.y : sy > 0 ? b.y + b.h : b.y + b.h / 2;
return svg`<circle class="dthandle dtedge dt-${cur}" cx="${x}" cy="${y}"
r="${hr.toFixed(1)}" @pointerdown=${(e: PointerEvent) =>
this._dtStart(e, 'scale', [sx, sy])}></circle>
<circle class="dtknob dtedgeknob" cx="${x}" cy="${y}" r="${kr.toFixed(2)}"></circle>`;
})
: corners.map(([sx, sy, cur]) => svg`<circle class="dthandle dt-${cur}"
cx="${sx < 0 ? b.x : b.x + b.w}" cy="${sy < 0 ? b.y : b.y + b.h}" r="${hr.toFixed(1)}"
@pointerdown=${(e: PointerEvent) => this._dtStart(e, 'scale', [sx, sy])}></circle><circle class="dtknob"
cx="${sx < 0 ? b.x : b.x + b.w}" cy="${sy < 0 ? b.y : b.y + b.h}" r="${kr.toFixed(2)}"></circle>`)))}
</g>` as unknown as TemplateResult;
}