german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-04 21:58:56 +00:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

fix: preserve wall identity through structural edits

Browse Source 
Issue: #282
User-Visible: yes
This commit is contained in:
Matysh
2026-08-26 02:20:57 +03:00
parent 2f155a83b9
commit e1059e2e29
21 changed files with 756 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/model-invariants.mjs
+3
View File
@@ -519,6 +519,7 @@ const pointOf = (value) => (Array.isArray(value) && isFiniteNumber(value[0])
*/
export function latticeProfile({ config, layout = {} } = {}) {
const buckets = { exact: 0, noise: 0, offGrid: 0 };
const offGridValues = new Set();
const byKind = new Map();
let worstNoise = null;
let total = 0;
@@ -526,6 +527,7 @@ export function latticeProfile({ config, layout = {} } = {}) {
for (const [axis, value] of [['x', point[0]], ['y', point[1]]]) {
const deviation = latticeDeviation(value);
const bucket = deviation === 0 ? 'exact' : deviation < NOISE_STEPS ? 'noise' : 'offGrid';
if (bucket === 'offGrid') offGridValues.add(Number(value).toFixed(12));
total++;
buckets[bucket]++;
const seen = byKind.get(kind) || { exact: 0, noise: 0, offGrid: 0 };
@@ -539,6 +541,7 @@ export function latticeProfile({ config, layout = {} } = {}) {
return {
total,
...buckets,
offGridUnique: offGridValues.size,
noiseSteps: NOISE_STEPS,
worstNoise,
byKind: Object.fromEntries([...byKind].map(([kind, counts]) => [kind, counts])),
scripts/mutation-gate.mjs
+64 -7
View File
@@ -435,8 +435,8 @@ export const MUTANTS = [
replace: ' const candidateValid = !!preview;',
}, {
file: 'src/houseplan-card.ts',
find: ' safe = this._checkSpacePhysicalGeometry(this._serverCfg, before.spaceId).ok;',
replace: ' safe = true;',
find: ' if (!legacySafe) {',
replace: ' if (false && !legacySafe) {',
}],
},
{
@@ -446,8 +446,39 @@ export const MUTANTS = [
+ 'the strict outbound barrier remains authoritative after the local restore (#293)',
patches: [{
file: 'src/houseplan-card.ts',
find: " && check?.reason === 'wall-degraded-extra');",
replace: ' && false);',
find: ' const physicalChanged = spacePhysicalGeometryFingerprint(before)\n'
+ ' !== spacePhysicalGeometryFingerprint(state);\n'
+ ' if (physicalChanged) {\n'
+ ' let safe = false;\n'
+ ' try {\n'
+ ' const check = restoredCandidate\n'
+ ' ? this._checkSpacePhysicalGeometry(restoredCandidate, state.spaceId)\n'
+ ' : null;\n'
+ " safe = !!check?.ok || !!(allowHistoryBoundaryRepair\n"
+ " && check?.reason === 'wall-degraded-extra');\n"
+ ' } catch { safe = false; }\n'
+ ' if (!safe) {',
replace: ' const physicalChanged = spacePhysicalGeometryFingerprint(before)\n'
+ ' !== spacePhysicalGeometryFingerprint(state);\n'
+ ' if (physicalChanged) {\n'
+ ' let safe = false;\n'
+ ' try {\n'
+ ' const check = restoredCandidate\n'
+ ' ? this._checkSpacePhysicalGeometry(restoredCandidate, state.spaceId)\n'
+ ' : null;\n'
+ ' safe = !!check?.ok;\n'
+ ' } catch { safe = false; }\n'
+ ' if (!safe) {',
}, {
file: 'src/houseplan-card.ts',
find: " // A history snapshot can predate the write-time wall degradation that\n"
+ " // canonicalized its command. Restore that one repairable baseline so\n"
+ " // Undo remains byte-exact immediately; _writeConfig still degrades and\n"
+ " // strictly validates the outbound candidate before it can leave the\n"
+ " // card. Every other preflight failure stays fail-closed.\n"
+ " safe = !!check?.ok || !!(allowHistoryBoundaryRepair\n"
+ " && check?.reason === 'wall-degraded-extra');",
replace: " safe = !!check?.ok;",
}],
},
{
@@ -2911,7 +2942,7 @@ export const MUTANTS = [
}],
},
{
id: 'wall-identity-structural-barrier-bypassed',
id: 'wall-identity-editor-commit-barrier-bypassed',
guard: 'npx tsc -p tsconfig.test.json && node scripts/fix-test-build.mjs '
+ '&& node --test --test-name-pattern="structural transaction crosses" '
+ 'test/wall-segment-model.test.mjs',
@@ -2919,8 +2950,34 @@ export const MUTANTS = [
+ 'stable ids can detach thickness and opening hosts during any later editor operation (#282)',
patches: [{
file: 'src/houseplan-card.ts',
find: ' this._serverCfg = commitWallSegmentModel(liveCandidate).config;',
replace: ' this._serverCfg = liveCandidate;',
find: ' } else committedCandidate = commitWallSegmentModel(liveCandidate).config;',
replace: ' } else committedCandidate = liveCandidate;',
}],
},
{
id: 'wall-identity-history-restore-barrier-bypassed',
guard: 'npx tsc -p tsconfig.test.json && node scripts/fix-test-build.mjs '
+ '&& node --test --test-name-pattern="structural transaction crosses" '
+ 'test/wall-segment-model.test.mjs',
because: 'Undo and Redo are a separate structural writer family; restoring a snapshot '
+ 'without rebuilding v8 references can persist stale room and opening identities (#282)',
patches: [{
file: 'src/houseplan-card.ts',
find: ' committedCandidate = commitWallSegmentModel(restoredCandidate).config;',
replace: ' committedCandidate = restoredCandidate;',
}],
},
{
id: 'wall-identity-optimize-barrier-bypassed',
guard: 'npx tsc -p tsconfig.test.json && node scripts/fix-test-build.mjs '
+ '&& node --test --test-name-pattern="structural transaction crosses" '
+ 'test/wall-segment-model.test.mjs',
because: 'Optimize repairs geometry outside the interactive editor; omitting its identity '
+ 'barrier would leave the authoritative catalogue behind the repaired projections (#282)',
patches: [{
file: 'src/plan-optimizer.ts',
find: ' wallSegmentsMigrated = commitWallSegmentModelInPlace(config).migratedSegments;',
replace: ' wallSegmentsMigrated = 0;',
}],
},
];