german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-02 12:49:56 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

fix: preserve resize undo through write repair

Browse Source 
Issue: #293
User-Visible: yes
This commit is contained in:
Sergey Matyunin
2026-08-24 17:46:20 +03:00
parent 08dce8603d
commit e2c1dbec0d
8 changed files with 61 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/houseplan-card.ts
+18 -6
View File
@@ -2727,7 +2727,7 @@ class HouseplanCard extends LitElement {
this._undoPoint();
return;
}
if (!this._applyGeometryState(command.before)) {
if (!this._applyGeometryState(command.before, true)) {
this._geometryHistory.clear();
return;
}
@@ -7289,7 +7289,9 @@ class HouseplanCard extends LitElement {
if (viewportGestureEnded && this._pointers.size === 0) this.requestUpdate();
}
private _applyGeometryState(state: SpaceGeometryState): boolean {
private _applyGeometryState(
state: SpaceGeometryState, allowHistoryBoundaryRepair = false,
): boolean {
if (!this._canCommitSpace(state.spaceId)) return false;
const before = this._geometrySnapshot(state.spaceId);
if (!before || !this._restoreGeometryStateLocal(state)) return false;
@@ -7297,8 +7299,18 @@ class HouseplanCard extends LitElement {
!== spacePhysicalGeometryFingerprint(state);
if (physicalChanged) {
let safe = false;
try { safe = !!this._serverCfg
&& this._checkSpacePhysicalGeometry(this._serverCfg, state.spaceId).ok; } catch { safe = false; }
try {
const check = this._serverCfg
? this._checkSpacePhysicalGeometry(this._serverCfg, state.spaceId)
: null;
// A history snapshot can predate the write-time wall degradation that
// canonicalized its command. Restore that one repairable baseline so
// Undo remains byte-exact immediately; _writeConfig still degrades and
// strictly validates the outbound candidate before it can leave the
// card. Every other preflight failure stays fail-closed.
safe = !!check?.ok || !!(allowHistoryBoundaryRepair
&& check?.reason === 'wall-degraded-extra');
} catch { safe = false; }
if (!safe) {
this._restoreGeometryStateLocal(before);
this._showToast(this._t('toast.geometry_unsafe'));
@@ -7342,7 +7354,7 @@ class HouseplanCard extends LitElement {
if (this._rszDrag) { this._rszCancelDrag(); return; }
const command = this._geometryHistory.undo();
if (!command) return;
if (!this._applyGeometryState(command.before)) {
if (!this._applyGeometryState(command.before, true)) {
this._geometryHistory.clear();
return;
}
@@ -7365,7 +7377,7 @@ class HouseplanCard extends LitElement {
if (this._rszDrag) { this._rszCancelDrag(); return; }
const command = this._geometryHistory.redo();
if (!command) return;
if (!this._applyGeometryState(command.after)) {
if (!this._applyGeometryState(command.after, true)) {
this._geometryHistory.clear();
return;
}