german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-07 15:09:30 +00:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

fix(iso): считать подсказку только верхней границей (#585)

Browse Source 
Кешированное смещение больше не завершает поиск до точной проверки пересечений с границами комнаты и стен. Добавлен регрессионный тест для более близкого решения у диагональной границы.

Issue: #585
User-Visible: no
This commit is contained in:
Claude
2026-09-20 02:29:42 +03:00
parent 630ae32a64
commit f5365f49c4
46 changed files with 479 additions and 438 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/iso-overlays.ts
+18 -6
View File
@@ -1376,9 +1376,13 @@ export function resolveIsoOverlayCollisions(
const baseCandidate = candidate(baseOffsetCss);
let best = baseCandidate;
let bestFromHint = false;
if (!best || best.conflicts.length) {
const hinted = item.nudgeHintCss ? candidate(item.nudgeHintCss) : null;
if (hinted && !hinted.conflicts.length) best = hinted;
if (hinted && !hinted.conflicts.length) {
best = hinted;
bestFromHint = true;
}
}
if (!baseCandidate || baseCandidate.conflicts.length) {
/**
@@ -1558,6 +1562,7 @@ export function resolveIsoOverlayCollisions(
placement: placementAtGroupOffset(base, offset, unitsPerPixel, false),
bounds: shape.bounds, conflicts: shape.conflicts, penalty: shape.penalty,
};
bestFromHint = false;
}
continue;
}
@@ -1568,10 +1573,13 @@ export function resolveIsoOverlayCollisions(
&& !!bestOffset && (offset[1] < bestOffset[1] - EPS
|| Math.abs(offset[1] - bestOffset[1]) <= EPS
&& offset[0] < bestOffset[0] - EPS);
if (wins) best = {
placement: placementAtGroupOffset(base, offset, unitsPerPixel, false),
bounds: shape.bounds, conflicts: shape.conflicts, penalty: shape.penalty,
};
if (wins) {
best = {
placement: placementAtGroupOffset(base, offset, unitsPerPixel, false),
bounds: shape.bounds, conflicts: shape.conflicts, penalty: shape.penalty,
};
bestFromHint = false;
}
}
if (wallWitness) pendingWalls.add(wallWitness.index);
};
@@ -1590,7 +1598,11 @@ export function resolveIsoOverlayCollisions(
next.forEach(addWallBoundary);
changed = true;
}
if (!changed && best && !best.conflicts.length) break;
// A verified hint is an upper bound, not proof of minimality. If none
// of the overlay events improves it, room/wall boundary intersections
// must still get one exact pass before the search may stop.
if (!changed && best && !best.conflicts.length
&& (!bestFromHint || fallbackAdded)) break;
if (!changed && !fallbackAdded) {
addFallbackBoundaries();
changed = true;