german/houseplan-card
1
0
Fork 0
mirror of https://github.com/Matysh/houseplan-card synced 2026-10-08 07:29:13 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

refactor: remove dead partition tool state

Browse Source 
Issue: #176
User-Visible: no
This commit is contained in:
Sergey Matyunin
2026-08-19 16:17:09 +03:00
parent 41e2cfffc6
commit f66e671b89
16 changed files with 142 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/golden-matrix.test.mjs
+1 -1
View File
@@ -69,7 +69,7 @@ test('golden matrix has stable unique ids and bounded comparison thresholds', ()
assert.equal(scenario.openHelp, scenario.helpTextRegion.key, scenario.id);
}
if (scenario.planSnap) {
assert.equal(['draw', 'partition'].includes(scenario.planSnap.tool), true, scenario.id);
assert.equal(scenario.planSnap.tool, 'draw', scenario.id);
assert.equal(['endpoint', 'line'].includes(scenario.planSnap.expectedKind), true, scenario.id);
assert.equal(scenario.mode, 'plan', scenario.id);
assert.equal(scenario.capture, 'page', scenario.id);
test/unified-wall-tool-source.test.mjs
+34
View File
@@ -0,0 +1,34 @@
import assert from 'node:assert/strict';
import { readFileSync } from 'node:fs';
import test from 'node:test';
const cardSource = readFileSync(new URL('../src/houseplan-card.ts', import.meta.url), 'utf8');
const en = JSON.parse(readFileSync(new URL('../src/i18n/en.json', import.meta.url), 'utf8'));
const ru = JSON.parse(readFileSync(new URL('../src/i18n/ru.json', import.meta.url), 'utf8'));
test('runtime exposes only the unified Walls tool state', () => {
const toolType = cardSource.match(/type MarkupTool = ([^;]+);/)?.[1] || '';
const toolSet = cardSource.match(/const MARKUP_TOOLS = new Set<MarkupTool>\(\[([\s\S]*?)\]\);/)?.[1] || '';
assert.doesNotMatch(toolType, /['"]partition['"]/);
assert.doesNotMatch(toolSet, /['"]partition['"]/);
assert.doesNotMatch(cardSource, /\b_partitionClick\b/);
assert.doesNotMatch(cardSource, /this\._tool\s*(?:===|!==)\s*['"]partition['"]/);
assert.doesNotMatch(cardSource, /['"]partition['"]\s*(?:===|!==)\s*this\._tool/);
});
test('only old tool copy is removed while persisted partition copy remains', () => {
for (const locale of [en, ru]) {
for (const key of [
'title.markup_partition',
'markup.hint_partition',
'physical.partition_size_title',
]) assert.equal(key in locale, false, key);
for (const key of [
'markup.partition',
'physical.partition_properties',
'history.partition_add',
]) assert.equal(typeof locale[key], 'string', key);
}
});