mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 11:18:48 +00:00
Claude
2a62ad5b95
The screenshot fingerprint and golden baselines stop being a tax on every task branch: - Task branches no longer commit docs/images/** or golden baselines. On a branch the screenshot freshness stays a preflight warning; the review prompt, REVIEWER.md and AUTHOR.md drop check-docs as a per-task gate. - beta-derived.yml refreshes them on dev in one bot commit before the beta candidate: canonical docs capture + docs:accept --reviewed, golden from the golden-images artifact of a completed Validate on dev + golden:accept --reviewed. A changed frame or scene is accepted only when named in the inputs; undeclared differences refuse. Baseline commits carry Release: and Baseline-Reviewed:; the subject is not a candidate subject. - classify-changes: the Release: trailer on an issue/* branch no longer switches on the heavy set. ci:full / ci:golden do: process-track emits full=true, the review gate dispatches Validate with full=true and does not accept a light proof. Canon: PROCESS.md §3 п.13, §5.1, §8, §11.4; CONTRIBUTING.md. Issue: #697 User-Visible: no Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qZfe7YS4rqEMKoVeS3GKd
63 lines
4.6 KiB
JavaScript
63 lines
4.6 KiB
JavaScript
// #697, PROCESS.md §8: отпечаток и кадры скриншотов, эталоны golden —
|
|
// одним коммитом бота на dev перед бетой, а не в каждой ветке задачи.
|
|
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
import { readFileSync } from 'node:fs';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { validateCommitMessage } from '../scripts/validate-commit-provenance.mjs';
|
|
import { isCandidateSubject } from '../scripts/bundle-policy.mjs';
|
|
|
|
const WORKFLOW = readFileSync(fileURLToPath(new URL('../.github/workflows/beta-derived.yml', import.meta.url)), 'utf8');
|
|
const step = (name) => {
|
|
const start = WORKFLOW.indexOf(` - name: ${name}\n`);
|
|
assert.ok(start > 0, `нет шага ${name}`);
|
|
const next = WORKFLOW.indexOf('\n - ', start + 10);
|
|
return next < 0 ? WORKFLOW.slice(start) : WORKFLOW.slice(start, next);
|
|
};
|
|
|
|
test('#697 бот: только по кнопке, прав на запись у job нет — пишет PAT одним push', () => {
|
|
assert.match(WORKFLOW, /^on:\n workflow_dispatch:\n/m);
|
|
assert.doesNotMatch(WORKFLOW, /^\s+(push|schedule|workflow_run):/m);
|
|
assert.match(WORKFLOW, /permissions:\n\s+contents: read\n\s+actions: read\n/);
|
|
assert.doesNotMatch(WORKFLOW, /contents: write/);
|
|
const commit = step('Коммит в dev');
|
|
assert.match(commit, /git push -q "https:\/\/x-access-token:\$TOKEN@github\.com\/\$\{\{ github\.repository \}\}" HEAD:dev/);
|
|
assert.doesNotMatch(commit, /--force/, 'ушедший dev — перезапуск, а не перезапись');
|
|
});
|
|
|
|
test('#697 бот: скриншоты принимаются по канону, изменённый кадр — только объявленный', () => {
|
|
const docs = step('Кадры документации — съёмка и приёмка');
|
|
assert.match(docs, /node demo\/docs\/capture\.mjs --stability=3/);
|
|
assert.match(docs, /git checkout -- docs\/images\n\s+git clean -fdq -- docs\/images/, 'приёмка сравнивает с закоммиченными кадрами');
|
|
assert.match(docs, /args=\(--reviewed "--from=\$cand"\)/);
|
|
assert.match(docs, /--expect-change=\$EXPECT/);
|
|
assert.match(docs, /EXPECT: \$\{\{ inputs\.docs_expect_change \}\}/);
|
|
assert.match(WORKFLOW, /OXIPNG_VERSION: 10\.2\.0/, 'тот же упаковщик, что docs-screenshots.yml');
|
|
const screenshots = readFileSync(fileURLToPath(new URL('../.github/workflows/docs-screenshots.yml', import.meta.url)), 'utf8');
|
|
assert.match(screenshots, /OXIPNG_VERSION: 10\.2\.0/);
|
|
});
|
|
|
|
test('#697 бот: эталоны golden — только из завершённого Validate на dev', () => {
|
|
const golden = step('Эталоны golden из прогона Validate');
|
|
assert.match(golden, /if: inputs\.golden_run != ''/);
|
|
assert.match(golden, /\[ "\$path" != "\.github\/workflows\/validate\.yml" \] \|\| \[ "\$branch" != "dev" \] \|\| \[ "\$status" != "completed" \]/);
|
|
assert.match(golden, /gh run download "\$RUN" --repo "\$\{\{ github\.repository \}\}" -n golden-images/);
|
|
assert.match(golden, /node scripts\/golden-accept\.mjs "\$\{args\[@\]\}"/);
|
|
});
|
|
|
|
test('#697 бот: сообщение коммита проходит провенанс и не выдаёт себя за кандидата', () => {
|
|
const commit = step('Коммит в dev');
|
|
assert.match(commit, /if \[ "\$GOLDEN_CHANGED" = "true" \]; then\n\s+echo "Release: \$TAG"\n\s+echo "Baseline-Reviewed: \$GOLDEN_URL"/,
|
|
'эталоны без Release: и Baseline-Reviewed: провенанс отклонит');
|
|
assert.match(commit, /echo "Issue: #697"\n\s+echo "User-Visible: no"/);
|
|
const subject = 'docs: accept derived artifacts on dev for v1.79.0-beta.1';
|
|
assert.match(commit, /echo "docs: accept derived artifacts on dev for \$TAG"/);
|
|
assert.equal(isCandidateSubject(subject), false, 'бандл кандидата у коммита бота не сверяется');
|
|
const golden = [subject, '', 'Производные артефакты беты.', '',
|
|
'Release: v1.79.0-beta.1', 'Baseline-Reviewed: https://github.com/o/r/actions/runs/1', 'Issue: #697', 'User-Visible: no'].join('\n');
|
|
assert.deepEqual(validateCommitMessage(golden, ['docs/images/screenshots.json', 'demo/golden/baselines/a.png']), []);
|
|
const docsOnly = [subject, '', 'Производные артефакты беты.', '', 'Issue: #697', 'User-Visible: no'].join('\n');
|
|
assert.deepEqual(validateCommitMessage(docsOnly, ['docs/images/screenshots.json']), []);
|
|
assert.notDeepEqual(validateCommitMessage(docsOnly, ['demo/golden/baselines/a.png']), [], 'эталоны без провенанса — отказ');
|
|
});
|