mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Codex
9d8f89d260
The gate used to require every Validate run on the tag SHA to be green: a cancelled duplicate or a red flake that a later re-run had fixed kept the stable release blocked (v1.73.0, 09.09 — released by hand). Now the verdict comes from the newest run that was not cancelled: not completed → wait, success → pass, anything else → fail, no run → wait. The same rule is documented for the perf workflow and the release runbook. Mutants: release-gate-counts-cancelled-runs, release-gate-oldest-run-wins. Issue: #511 User-Visible: no
64 lines
3.6 KiB
JavaScript
64 lines
3.6 KiB
JavaScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { readFileSync } from 'node:fs';
|
|
import { classifyValidateRuns, latestRelevantRun, workflowRunsUrl } from '../scripts/release-gate.mjs';
|
|
|
|
test('release gate waits until an exact-SHA Validate exists and completes', () => {
|
|
assert.equal(classifyValidateRuns([]), 'wait');
|
|
assert.equal(classifyValidateRuns([{ status: 'queued', conclusion: null }]), 'wait');
|
|
assert.equal(classifyValidateRuns([
|
|
{ id: 1, run_started_at: '2026-09-09T13:01:00Z', status: 'completed', conclusion: 'success' },
|
|
{ id: 2, run_started_at: '2026-09-09T13:02:00Z', status: 'in_progress', conclusion: null },
|
|
]), 'wait');
|
|
});
|
|
|
|
test('release gate accepts only completed success runs', () => {
|
|
assert.equal(classifyValidateRuns([
|
|
{ status: 'completed', conclusion: 'success' },
|
|
{ status: 'completed', conclusion: 'success' },
|
|
]), 'success');
|
|
});
|
|
|
|
test('release gate fails closed for red, timed-out and skipped runs (cancelled ones are not verdicts, #511)', () => {
|
|
for (const conclusion of ['failure', 'timed_out', 'action_required', 'skipped', null]) {
|
|
assert.equal(
|
|
classifyValidateRuns([{ status: 'completed', conclusion }]),
|
|
'fail',
|
|
`completed/${conclusion} must withhold the asset`,
|
|
);
|
|
}
|
|
});
|
|
|
|
test('#511: the latest non-cancelled run is the verdict; cancelled runs prove nothing', () => {
|
|
const at = (minute, over) => ({ id: minute, run_started_at: `2026-09-09T13:${String(minute).padStart(2, '0')}:00Z`, status: 'completed', ...over });
|
|
// an older green does not outrank a newer red …
|
|
assert.equal(classifyValidateRuns([at(1, { conclusion: 'success' }), at(2, { conclusion: 'failure' })]), 'fail');
|
|
// … and a newer green (re-run, dispatch with another baseline) refreshes an older red
|
|
assert.equal(classifyValidateRuns([at(1, { conclusion: 'failure' }), at(2, { conclusion: 'success' })]), 'success');
|
|
// order in the payload is irrelevant: the timestamp decides
|
|
assert.equal(classifyValidateRuns([at(2, { conclusion: 'success' }), at(1, { conclusion: 'failure' })]), 'success');
|
|
// cancelled twins are invisible
|
|
assert.equal(classifyValidateRuns([at(1, { conclusion: 'cancelled' })]), 'wait');
|
|
assert.equal(classifyValidateRuns([at(2, { conclusion: 'cancelled' }), at(1, { conclusion: 'success' })]), 'success');
|
|
assert.equal(classifyValidateRuns([at(2, { conclusion: 'cancelled' }), at(1, { conclusion: 'failure' })]), 'fail');
|
|
// a newer run still going means wait, even with an older green behind it
|
|
assert.equal(classifyValidateRuns([at(1, { conclusion: 'success' }), at(2, { status: 'in_progress', conclusion: null })]), 'wait');
|
|
assert.equal(latestRelevantRun([at(2, { conclusion: 'cancelled' }), at(1, { conclusion: 'success' })]).id, 1);
|
|
assert.equal(latestRelevantRun([]), null);
|
|
});
|
|
|
|
test('release gate can target the dedicated exact-SHA performance workflow', () => {
|
|
assert.equal(
|
|
workflowRunsUrl({ repo: 'Matysh/houseplan-card', workflow: 'performance.yml', sha: 'abc/123' }),
|
|
'https://api.github.com/repos/Matysh/houseplan-card/actions/workflows/performance.yml/runs?head_sha=abc%2F123&per_page=100',
|
|
);
|
|
});
|
|
|
|
test('#511 AC3: the release documents describe the latest-run semantics', () => {
|
|
const development = readFileSync(new URL('../docs/DEVELOPMENT.md', import.meta.url), 'utf8');
|
|
assert.match(development, /latest non-cancelled Validate run of the\nSHA/);
|
|
assert.doesNotMatch(development, /A missing, failed,\ncancelled or one-hour-timed-out Validate withholds/);
|
|
const performance = readFileSync(new URL('../demo/performance/README.md', import.meta.url), 'utf8');
|
|
assert.match(performance, /latest\nnon-cancelled run on the SHA/);
|
|
});
|