houseplan-card

mirror of https://github.com/Matysh/houseplan-card synced 2026-09-29 03:09:36 +00:00

Files

T

Matysh 33470306d2 fix: keep the review document outside the tree the reviewer mutates

Three code-review rounds on #220 published a verdict and then failed the
run: the document never reached the branch, so the #171 guard refused
before the label step and neither the merge nor S8-merged happened. The
cause was structural. The document lived as an untracked file inside the
very checkout the reviewer edits while proving that a test can fail, and
restoring that tree — git checkout, git clean — deletes an untracked file.
Spec rounds survived only because they never mutate anything.

The reviewer now writes to REVIEW_DOC under RUNNER_TEMP, outside the
repository, and the publish step copies it into docs/reviews before
committing. Tree cleanup can no longer destroy the artefact, and the
reviewer no longer needs to touch docs/reviews at all.

Verified against a local git fixture on five paths: document outside the
repo with a mutated tree, nothing anywhere (loud failure), document only in
the working copy, document already committed by the reviewer, and a branch
that moved during the review.

Same file as main, byte for byte.

Issue: #220
User-Visible: no

2026-08-21 10:53:07 +03:00

announce.yml

ci: move workflows to Node 24 actions

2026-08-16 00:00:36 +03:00

mutation-gate.yml

fix: preserve plan-only room label scale

2026-08-17 13:16:04 +03:00

performance.yml

fix: cache Playwright browsers instead of reinstalling them via apt

2026-08-19 20:06:38 +03:00

process.yml

fix: keep the review document outside the tree the reviewer mutates