mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Matysh
63a8274623
The v1.55.2 recheck (verdict NEEDS FIX) found two lifecycle holes in the first-open boot veil (HP-1552); both are closed here and covered by demo/smoke_preloader_lifecycle.mjs, which fails on v1.55.2. AUD-1552-01 (high): disconnect/reconnect while booting hid the plan FOREVER. disconnectedCallback cleared the boot timer but kept its truthy id, so 'updated()' never restarted the watcher. Now the id is nulled on disconnect and connectedCallback restarts the whole veil lifecycle: a fresh watch (fresh clock, BOOT_MAX_MS hard cap) while booting, the tail timers when detached mid-fade or mid-grace. AUD-1552-02 (medium): two equal reads at 200/400 ms revealed the plan at ~400 ms, so HA chrome landing at 450+ ms jumped on a VISIBLE plan. The veil now holds a full protective window (BOOT_MIN_MS=700 — the old 600 ms plus a frame-latency margin: a shift applied at ~590 ms only materializes in the stage height a couple frames later) with 100 ms sampling and trailing quiescence (BOOT_QUIET_MS=250 restarts on every height change), capped by BOOT_MAX_MS=1200. After the reveal a short soft grace (BOOT_SOFT_MS=1500, .stage.hpsettle) turns later passive shifts into a 0.25 s height glide — the viewport ResizeObserver refits the plan along the transition; deliberate height changes (_setMode into an editor) cancel the grace so the plan never drifts under the pointer. Reduced motion disables the glide. Regressions (demo/smoke_preloader_lifecycle.mjs, all FAIL on v1.55.2): - A: detach before the first tick -> reattach -> veil lifts within the cap, plan visible, no hpboot class, no zombie veil after a mid-fade remount either; - B: parameterized layout shifts at 150/300/450/590 ms -> not a single frame shows the plan at a non-final stage height; - C: a shift after the reveal glides (>=3 intermediate frames), no snap. smoke_modes.mjs now strips the transient hpsettle class from its exact stage-class assertions. Docs: CHANGELOG en+ru, STATUS.
88 lines
4.2 KiB
JavaScript
88 lines
4.2 KiB
JavaScript
// UX modes shell (v1.25.0): view is display-only; plan/devices gate the tools.
|
||
import { launch, checkAll, finish } from './serve.mjs';
|
||
const { page, browser } = await launch();
|
||
const out = {};
|
||
const q = (sel) => page.evaluate((s) => (window.__card.shadowRoot || window.__card.renderRoot).querySelectorAll(s).length, sel);
|
||
const st = () => page.evaluate(() => {
|
||
const c = window.__card;
|
||
const sr = c.shadowRoot || c.renderRoot;
|
||
return {
|
||
mode: c._mode,
|
||
modeTabs: sr.querySelectorAll('.modetab').length,
|
||
active: sr.querySelector('.modetab.active')?.textContent.trim(),
|
||
editBtns: sr.querySelectorAll('.head .btn:not(.zb)').length,
|
||
gears: sr.querySelectorAll('.tabedit').length,
|
||
markupBar: !!sr.querySelector('.editbar'),
|
||
// hpsettle is the transient post-boot grace (AUD-1552-02), not a mode class
|
||
stageClass: sr.querySelector('.stage').className.replace(/ ?\bhpsettle\b/, ''),
|
||
};
|
||
});
|
||
// 1) старт: view, чистая шапка
|
||
out.start = await st();
|
||
// 2) drag в view ничего не двигает и не мешает пану
|
||
await page.evaluate(() => {
|
||
const c = window.__card;
|
||
const d = c._devices.find((x) => x.space === 'f1');
|
||
const before = { ...c._pos(d) };
|
||
c._pointerDown({ preventDefault(){}, clientX: 10, clientY: 10, target: { setPointerCapture(){} }, pointerId: 1 }, d);
|
||
c._pointerMove({ clientX: 90, clientY: 60 }, d);
|
||
c._pointerUp({}, d);
|
||
const after = { ...c._pos(d) };
|
||
window.__viewDragMoved = Math.abs(after.x - before.x) + Math.abs(after.y - before.y) > 0.5;
|
||
clearTimeout(c._holdTimer);
|
||
});
|
||
out.viewDragMoved = await page.evaluate(() => window.__viewDragMoved);
|
||
// long-press в view открывает инфо
|
||
await page.evaluate(async () => {
|
||
const c = window.__card;
|
||
const d = c._devices.find((x) => x.space === 'f1');
|
||
c._pointerDown({ preventDefault(){}, clientX: 10, clientY: 10, target: { setPointerCapture(){} }, pointerId: 2 }, d);
|
||
await new Promise((r) => setTimeout(r, 700));
|
||
});
|
||
out.viewHoldInfo = await page.evaluate(() => { const r = !!window.__card._infoCard; window.__card._infoCard = null; window.__card._holdFired = false; return r; });
|
||
// 3) режим План
|
||
await page.evaluate(() => window.__card._setMode('plan'));
|
||
await page.waitForTimeout(200);
|
||
out.plan = await st();
|
||
out.planIconsHidden = await page.evaluate(() => {
|
||
const sr = window.__card.shadowRoot || window.__card.renderRoot;
|
||
const dev = sr.querySelector('.dev');
|
||
return dev ? getComputedStyle(dev).display === 'none' : 'no-dev';
|
||
});
|
||
// 4) режим Устройства: drag работает, клик открывает редактор
|
||
await page.evaluate(() => window.__card._setMode('devices'));
|
||
await page.waitForTimeout(200);
|
||
out.devices = await st();
|
||
out.devDragWorks = await page.evaluate(() => {
|
||
const c = window.__card;
|
||
const d = c._devices.find((x) => x.space === 'f1');
|
||
const before = { ...c._pos(d) };
|
||
c._pointerDown({ preventDefault(){}, clientX: 10, clientY: 10, target: { setPointerCapture(){} }, pointerId: 3 }, d);
|
||
c._pointerMove({ clientX: 100, clientY: 70 }, d);
|
||
c._pointerUp({}, d);
|
||
const after = { ...c._pos(d) };
|
||
return Math.abs(after.x - before.x) + Math.abs(after.y - before.y) > 0.5;
|
||
});
|
||
out.devClickOpensEditor = await page.evaluate(async () => {
|
||
const c = window.__card;
|
||
c._drag = null;
|
||
const d = c._devices.find((x) => x.space === 'f1');
|
||
c._clickDevice({ stopPropagation(){} }, d);
|
||
await c.updateComplete;
|
||
const r = !!c._markerDialog;
|
||
c._markerDialog = null;
|
||
return r;
|
||
});
|
||
// 5) назад в view
|
||
await page.evaluate(() => window.__card._setMode('view'));
|
||
out.backToView = (await st()).mode;
|
||
// значения зафиксированы прогоном на v1.43.1 и сверены с кодом (audit T1)
|
||
checkAll(out, {
|
||
"start": {"mode": "view", "modeTabs": 3, "editBtns": 1, "gears": 2, "markupBar": false, "stageClass": "stage mode-view"},
|
||
"viewDragMoved": false,
|
||
"plan": {"mode": "plan", "modeTabs": 3, "active": "Plan editor", "editBtns": 1, "gears": 2, "markupBar": true, "stageClass": "stage markup tool-draw mode-plan"},
|
||
"devices": {"mode": "devices", "modeTabs": 3, "active": "Device editor", "editBtns": 1, "gears": 2, "markupBar": true, "stageClass": "stage mode-devices"},
|
||
"backToView": "view",
|
||
});
|
||
await finish(browser, out);
|