mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Matysh
1e9952db35
A green code review whose merge conflicted used to leave the label where it was. That is a dead end: the author waits for the label to change, so it polled thirty times and reported the limit as exhausted — on a task the reviewer had already passed. The verdict existed and nobody could act on it. The merge step no longer fails the job. It reports whether it merged, and a green review that did not merge sends the task back to S6-in-progress, because the work did return to the author — a rebase rather than a code fix, and the comment says so and says the verdict still stands. The invariant is now stronger and worth stating plainly: after a review run the label always changes. A pipeline whose state can stall silently is worse than one that reports the wrong state loudly. Issue: #114 User-Visible: no