Files
houseplan-card/demo/performance
Claude e5ab4659f6 feat: 2.5D stage 6 — public setting, raised tiles, soft sun, theme-free walls (#649)
- settings.volumetric_view (General settings › Display, third switch) replaces
  the alpha entry, the header projection toggle and the phone-menu item; one
  rule for card, sidebar page and kiosk; editors stay Flat; backend accepts
  only a boolean, support package copies it.
- Raised tiles in 2.5D View: no ring, rounded body min(0.275 D, 0.3 h), edge
  0.1 D with the lab filters, ×1.12 size also in layout/collision, lift
  0.075 D, one floor-shadow layer under all markers (theme × floor table),
  frames hugging tile and edge (Alert > Focus > Selected > Hover), forced
  colours without edge and shadow (src/iso-tiles.ts, styles/iso-tiles).
- Soft sun wash instead of projected Flat wedges (src/iso-sun.ts): same gates
  and windows as sun_rays, length from elevation, parallelogram along the sun,
  tone and streaks by floor lightness, sill line.
- Walls take the user's wall colour (top opaque, sides × .77/.68/.60); theme
  rules for walls/openings/labels removed; furniture uses the Flat stroke rule.
- Smokes smoke_iso_tiles/iso_sun/iso_theme_walls/volumetric_setting, 16 new
  mutants, acceptance scenes STAGE6_ACCEPTANCE_SCENARIOS (golden with their
  Linux CI baselines), ACCEPTANCE.md side by side.

Issue: #649
User-Visible: yes
2026-09-25 18:55:14 +03:00
..
2026-09-06 07:06:54 +03:00

Large-house performance gate

benchmark_large_house.mjs exercises the deterministic large-house-v1 fixture. The fixture has 60 rooms, 200 devices, 100 openings, 60 partitions, 40 columns and 500 decor objects on three floors.

Issue #89 adds large-house-isometric-v1 through the same runner. The runner enables the current candidate through the real hp_alpha=1 URL/storage contract, selects iso per fixture space, measures the View toggle and records the capped isoGeometry cache. A compatibility-only snapshot keeps comparison bundles from before #448 measurable without restoring a legacy user-facing activation path; a comparison SHA predating #89 remains flat while reporting the same profile. The dedicated budgets-large-house-isometric.json applies the reviewed 20% relative allowance plus absolute noise/ceiling checks. Only the exact-SHA Linux workflow is gate evidence; a local report is diagnostic.

Issue #160 keeps that historical profile and budget unchanged, then adds the separate isometric-stage3-dense-v1 profile. Its derived performance-only fixture puts all 200 devices close to walls or corners and adds deterministic value, LQI and new-device badges plus contact/lock-bound door, window and gate examples. The base invocation explicitly allows a Stage 2 renderer so an older dev SHA remains measurable; the candidate invocation fails closed unless it reports effective Iso, the Stage 3 revision, all required raised overlay kinds, at least one real nudge, a bounded shared material-definition set and zero structural rebuilds during HA, opening and hover/focus updates. The two extra timing windows use limits no softer than the historical HA-update budget. This does not change the fixture, measured windows or budget of large-house-isometric-v1, which remains the #124 regression witness.

Issue #137 adds large-house-plan-snap-v1 without changing the meaning or budgets of the original profile. The same 60-room/60-partition fixture gains six saved open outlines, renders the Plan snap overlay, and sends 120 real pointer moves across endpoint, line and miss targets. Candidate bundles fail inside the runner if the static DOM or geometry cache grows, more than one active node appears, endpoint/line paths are not both exercised, or config and websocket traffic change. Its dedicated budget retains every original timing, heap and cache ceiling and adds the measured pointer series plus a one-entry snap-geometry cache cap. Exact-SHA Linux output is the only gate evidence.

Issue #451 adds large-house-interaction-v1. It dispatches 120 real device/room/free-background hover moves, four 20-move pans, pinch/wheel camera input, three editor drag series and 30 unrelated HA snapshots. It also injects relevant snapshots inside and outside a gesture and counts heavy _renderBody() passes plus full marker-binding diagnostic scans. Current bundles fail inside the runner unless hover, editor moves and unrelated ticks perform zero full renders, a relevant tick is deferred during pan, each terminal event reconciles at most one full frame, the heavy wall DOM remains identical, and the projected HTML device layer stays within one CSS pixel of its SVG scene position. Older comparison bundles still produce timing baselines; structural assertions become mandatory only when the target source contains the live viewport implementation. Its dedicated budget preserves every existing large-house ceiling and adds the individual interaction timing gates.

Structural assertions are evaluated independently of timing budgets: a fast run still fails when an interaction performs an unexpected full render or changes the heavy scene DOM.

The runner records seven measured samples after one discarded warm-up. With this intentionally small CI sample, the nearest-rank p95 is the observed maximum; reports keep the conventional field name but should be read as a high-tail guard rather than a population estimate:

  • model readiness and first stable render;
  • space switch, HA state update, pan/zoom and opening the settings dialog;
  • a shared-wall room-resize preview which is cancelled before persistence;
  • a twelve-switch navigation cycle;
  • Long Tasks for every measured window;
  • heap growth after four additional navigation rounds with forced GC;
  • hot-cache size and growth after the same warmed cycles.

Every report is tied to the source fingerprint embedded by Rollup. A stale bundle is a hard failure.

CI contracts

Ordinary pushes, pull requests and prereleases use the blocking performance_smoke job in validate.yml. It builds only the candidate and measures the heaviest 60-source large-house-glow-overlay-v1 state after one warm-up, with three recorded samples. compare.mjs --absolute-only enforces the reviewed hard timing, Long Task, heap, cache and rendered-device ceilings from budgets-glow-smoke.json; it deliberately makes no noisy base-relative claim. This is a catastrophic-regression guard, not a performance trend detector.

Two more profiles join the smoke only when the diff touches their code path (#473, classified by scripts/classify-changes.mjs): large-house-isometric-v1 for src/iso-* and large-house-interaction-v1 for src/live-*, src/render-*, houseplan-render-lifecycle.ts and houseplan-card.ts. Both run --samples=3 --warmups=1 against budgets-isometric-smoke.json and budgets-interaction-smoke.json, whose ceilings are the hardMaxMs values of the full profiles. The set of profiles is part of the performance_smoke reuse key, so a glow-only success never stands in for a run that needed the isometric profile.

The interaction profile keeps strict per-series, Long Task, heap, cache and structural limits. Its aggregate interactionSeriesMs ceiling is 3300 ms: enough headroom for the observed hosted-runner baseline (up to 3122.6 ms), but still below the known failed pre-optimization result (3501.5 ms). This aggregate is a catastrophic guard; the full workflow's base-relative comparison remains the detector for smaller regressions.

The dedicated performance.yml workflow is the full comparison. It runs on every main promotion, weekly and on manual dispatch for an important beta or performance-sensitive change. It checks out the candidate and its base SHA, builds both, and runs them sequentially with the same Node.js 22 process family, pinned Playwright Chromium and hosted runner. compare.mjs then applies two limits:

  1. a relative regression allowance against the base-SHA report;
  2. an absolute safety ceiling from budgets.json.

Which base SHA the relative half compares against is decided by scripts/performance-baseline.mjs, not by the workflow's shell (#587). A stable release candidate — its head commit carries a Release: trailer without a prerelease suffix — is compared against the previous stable tag; everything else keeps the old base (push before, the candidate parent, or the comparison_ref a manual dispatch names). The reason is the order the stable gate imposes: the candidate must be on main before this workflow can run on its exact SHA, so the next commit of the same line would otherwise take the first one as its base and compare the line with itself — a red gate would be cleared by any follow-up commit. The negative cases of that decision (no tag, a tag sitting on HEAD, a base that is no longer an ancestor) cannot be exercised from YAML, so they live in test/performance-baseline.test.mjs with an injected git; the mutant stable-candidate-compares-against-itself puts the old behaviour back and must be caught.

The tighter limit wins. The absolute values are catastrophic safety ceilings, not normal-performance targets; the base-relative comparison catches smaller regressions. Small fast operations receive an absolute noise allowance so normal scheduler jitter does not become a false regression. Heap, Long Tasks, warmed-cache growth and the expected rendered-device count are gated separately. Long-Task maximum/count/total checks use the same relative-plus-absolute policy as timings. Each independent profile pair runs in parallel with the other pairs, but its base and candidate remain sequential on one runner. Its raw reports and comparison are uploaded as full-performance-<profile>, and the table is written to that GitHub job summary. Stable release assets require both exact-SHA Validate and exact-SHA Full Performance; prereleases require only Validate. The gate (scripts/release-gate.mjs, #511) judges by the latest non-cancelled run on the SHA: a re-run or a manual comparison against another baseline refreshes the verdict, and a cancelled twin is invisible.

This base-vs-candidate design intentionally does not compare timings captured on different machines or different Chromium builds. A runtime/profile mismatch fails closed.

Before the base checkout, CI fetches the complete commit graph and verifies the requested comparison revision. A main push uses github.event.before, which must both exist and remain an ancestor of the candidate; this catches the unreachable SHA left by a force-push. A manual run may name an explicit tag, branch or SHA, while an empty manual input and the weekly run use the candidate parent. An unusable requested revision falls back with a warning to the direct parent, then to the newest reachable semver release. If no safe comparison exists, the job fails closed instead of comparing against an arbitrary commit.

Private card contract

The candidate benchmark runner is also executed against the base bundle, so every private houseplan-card field or method it reads is an explicit API of the performance harness. card-contract.mjs lists that surface for the large-house and Glow profiles. Each runner verifies it immediately after card creation and fails with the exact missing names or invalid runtime types before waiting for readiness or recording timings. Required caches must be real Map instances and must never be converted from missing/invalid values to plausible zeroes.

fields are required in every supported comparison base. optionalFields are newer members whose absence has an explicit safe fallback in the runner; if an optional member exists, its declared fieldTypes contract still applies. Add a new safely degradable field to optionalFields until every supported base has it, then promote it to fields. A member without a truthful fallback must be introduced through a compatibility revision before the benchmark consumes it.

Rename a consumed private member in two revisions:

  1. teach the contract and every reader to understand both the old and proposed name while production still exposes the old name; land that compatibility revision so it can become a comparison base;
  2. rename the production member and prefer the new name while retaining the old reader fallback. Remove the fallback only after all supported comparison bases expose the new member.

This sequencing keeps the current harness capable of profiling both source trees. A one-step rename that merely edits the candidate reader is forbidden: it would make the same runner incompatible with its base bundle.

Local diagnostics

Wall draw terminal clicks

wall-draw-click-v1 (#461) loads the production bundle with five spaces. The edited space contains 12 rooms, 48 positive-thickness wall atoms and four saved open drafts, then places seven consecutive Walls segments after warm-up. A second variant doubles remote, non-interacting room geometry. The runner fails structurally unless every intermediate click performs zero full-space physical checks, exactly one local physical check, reuses its wall artifact in the junction proof, adds one history entry and queues one full-config write. The chain finish must independently return to the full-space barrier.

The canonical Linux ceilings are 150 ms median and 250 ms maximum for the seven base clicks; the remote median may not exceed base × 1.5 + 20 ms. Counters are the primary verdict, so a fast machine cannot hide a route back through the generic barrier. Run against a freshly synchronized bundle:

npm run benchmark:wall-draw-click -- --output=artifacts/performance-smoke/wall-draw-click.json
node demo/smoke_wall_draw_click.mjs

Build and copy a fresh demo bundle first, then run:

npm run benchmark:large-house -- --samples=7 --warmups=1 --output=artifacts/performance/local.json
npm run benchmark:large-house-isometric -- --samples=7 --warmups=1 --output=artifacts/performance/isometric-local.json
npm run benchmark:isometric-stage3-dense -- --samples=7 --warmups=1 --output=artifacts/performance/isometric-stage3-local.json
npm run benchmark:large-house-plan-snap -- --samples=7 --warmups=1 --output=artifacts/performance/plan-snap-local.json
npm run benchmark:large-house-interaction -- --samples=7 --warmups=1 --output=artifacts/performance/interaction-local.json

A local report is diagnostic only; it cannot replace the CI comparison.

To reproduce the comparison against another checkout using one harness and one browser installation:

npm run benchmark:large-house -- --target-root=../base --samples=7 --output=artifacts/performance/baseline.json
npm run benchmark:large-house -- --target-root=. --samples=7 --output=artifacts/performance/candidate.json
npm run benchmark:compare

Changing budgets

Budget changes require an explicit review of recent CI artifacts and a written rationale in the change. Do not loosen a threshold merely to make a single red run pass. A new fixture profile gets a new profile id instead of silently changing the meaning of large-house-v1.

large-house-isometric-v1 and its Stage 3 dense twin carry countNoiseAllowance: 5 (the other profiles keep 3). Owner decision 2026-09-09, #507: since v1.73.0-beta.1 the isometric renderer lives in the lazy iso-scene-render chunk (#160 Stage 3), so the single v1.72.0 boot task is split into two around that import. The load-phase work is unchanged — timings, longTask.totalP95Ms and longTask.maxSingleMs keep their unchanged ratios and still catch real growth — but longTask.countP95 counts the split as +2 tasks and, with runner jitter, sat at 16 → 20 against a 19.2 limit on the v1.73.0 stable comparison. The allowance widens the count check alone to 16 → 21 for that baseline; it is not a licence for more work per task.

The same two isometric profiles carry a widened gesture allowance: resizePreviewMs 450 ms, panZoomMs 150 ms and stateUpdateMs 120 ms, held identical on both profiles because the #160 contract requires the Stage 3 dense twin to share every common ceiling with large-house-isometric-v1. Owner decision 2026-09-16, #585: the Full Performance run of the v1.76.0 stable candidate against v1.75.0 (run 35097102695) measured resizePreview 603 → 981 ms and panZoom 91 → 205 ms in the hidden 2.5D view. The step is real and understood — #583 gives that view more geometry, and the overlay-collision search still costs about twice what it did before #583, even after the coarse-lattice speed-up. Absolute ceilings did not move (panZoom 205 against 600, resize 981 against 2200) and every user-visible profile stayed green. The lever is milliseconds, not the ratio: it absorbs one level shift and still gates growth from the new level. #585 rewrites the search to enumerate obstacle boundaries instead of scanning the 48 px disc; when it lands, these allowances go back to 150/60/75.

The cleanFloor entry ceiling is 100: the reviewed fixture warms exactly 100 deterministic room/physical-body entries. An extra 20 means that one complete floor was invalidated and rebuilt, so fixture extensions must recalibrate this ceiling explicitly instead of receiving silent cache headroom.

Glow profiles

The full-card Glow profiles run deterministic 1/10/30/60-pool variants at DPR 1 and Chromium CPU throttling x4, but deliberately exercise different fixtures:

  • large-light-blend-v1 compares the isolated screen group with the previous normal-layer implementation on the shared frontend/backend schema fixture test/fixtures/glow/additive-pools.json;
  • large-house-glow-overlay-v1 measures simultaneous temperature fill and independent Glow on the existing 60-room/200-device large-house fixture, without changing large-house-v1.

The same runner also owns the two static-card profiles introduced with #374:

  • large-space-card-default-v1 proves that the default-off card keeps the historical no-visibility-work path and a zero-entry Glow cache;
  • large-space-card-glow-v1 measures the explicit light_pools:true path on one large static space, including HA ticks, heap/cache growth and capture.
npm run benchmark:glow -- --profile=large-light-blend-v1 --output=artifacts/performance/glow.json
npm run benchmark:glow -- --profile=large-house-glow-overlay-v1 --output=artifacts/performance/overlay.json
npm run benchmark:glow -- --profile=large-space-card-default-v1 --output=artifacts/performance/space-default.json
npm run benchmark:glow -- --profile=large-space-card-glow-v1 --output=artifacts/performance/space-glow.json
npm run benchmark:glow -- --profile=large-house-glow-overlay-v1 --variants=60 --samples=3 --warmups=1 --output=artifacts/performance-smoke/candidate.json
npm run benchmark:compare -- --absolute-only --budgets=demo/performance/budgets-glow-smoke.json --candidate=artifacts/performance-smoke/candidate.json --output=artifacts/performance-smoke/comparison.json
npm run benchmark:glow -- --profile=large-space-card-glow-v1 --variants=60 --samples=3 --warmups=1 --output=artifacts/performance-smoke/space-candidate.json
npm run benchmark:compare -- --absolute-only --budgets=demo/performance/budgets-space-glow-smoke.json --candidate=artifacts/performance-smoke/space-candidate.json --output=artifacts/performance-smoke/space-comparison.json

Reports include per-variant state-update timings, render/pool counts, Long Tasks, screenshot time, heap and cache growth. The first CI comparison against a base SHA that predates glow_enabled bootstraps only the overlay profile's relative baseline from the candidate; its absolute ceilings still gate that introduction. Every subsequent revision compares both profiles to the real base SHA.

The initial absolute ceilings are intentionally conservative bootstrap limits; they must be reviewed against the first paired Ubuntu artifacts before the feature is promoted from beta. Same-runner relative checks in the full workflow remain the primary regression signal; the candidate-only smoke only guards against catastrophic failures.