mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-30 19:58:50 +00:00
Codex
0f36ef55d5
CODE-REVIEW-316-r1 H1: the §3.3 degraded pool picked an angle-compatible wall at ANY distance, but the backend geometry-match invariant («wall opening geometry must match its host») requires the host to agree with the opening's own x/y — the migrated document was rejected by CONFIG_SCHEMA and the write wedged again on the schema layer. The pool is removed from both migrations (TS and the Python mirror): without an in-place eligible carrier the opening goes straight to the unhosted degraded state, exactly the alternative the spec's «assumed freely changeable» section reserved; the spec is revision 6. New tests replay the reviewer's reproduction on both sides, and the frontend test is proven able to fail by restoring the pool (executed red). CODE-REVIEW-316-r2 M2: the schema-level host check is shared with #132 partition openings, so its unhosted relaxation is now pinned by a regression test — a stale writer that keeps a partition-hosted opening but silently drops its host is still rejected by validate_partition_opening_hosts. Issue: #316 User-Visible: no