mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-30 11:49:16 +00:00
Codex
5c4d8cba9e
CODE-REVIEW-399-r1 High: the test named after AC5 called installsPythonDeps on string literals and never executed the directory walk it was supposed to protect. The reviewer showed what that costs: restoring the old hardcoded pair of real names and dropping a third workflow with unpinned installs into .github/workflows left all ten checks green — the exact scenario AC5 describes went undetected. The walk is now a function taking the directory, so the test can run it for real: it builds a temporary directory with three files (a pinned installer, a workflow that installs nothing, and a rogue one) and asserts on what the scanner returns. Reverting the walk to a list of two real names now reddens this test, verified by hand. The mutant is sharpened accordingly: it substitutes the two-name list instead of a one-name list. The old form failed on an unrelated assertion about directory size, so it proved nothing about the scan itself — while the two-name form is indistinguishable from correct code on today's tree, which is what makes it the likely regression. User-Visible: no Issue: #399