Matysh 5fdedf39d6 fix: keep the review document outside the tree the reviewer mutates ...

Three code-review rounds on #220 published a verdict and then failed the
run: the document never reached the branch, so the #171 guard refused
before the label step and neither the merge nor S8-merged happened. The
cause was structural. The document lived as an untracked file inside the
very checkout the reviewer edits while proving that a test can fail, and
restoring that tree — git checkout, git clean — deletes an untracked file.
Spec rounds survived only because they never mutate anything.

The reviewer now writes to REVIEW_DOC under RUNNER_TEMP, outside the
repository, and the publish step copies it into docs/reviews before
committing. Tree cleanup can no longer destroy the artefact, and the
reviewer no longer needs to touch docs/reviews at all.

Verified against a local git fixture on five paths: document outside the
repo with a mutated tree (published, and the code mutation does not leak),
nothing anywhere (loud failure, exit 1), document only in the working copy
(still published — the clean exclusion stays for exactly this), document
already committed by the reviewer (recognised, no duplicate), and a branch
that moved during the review (rebased, both commits kept).

Issue: #220
User-Visible: no

2026-08-21 10:32:21 +03:00

..

ISSUE_TEMPLATE

docs v1.44.1: add the Telegram community chat (@ha_houseplan)

2026-07-27 12:51:48 +03:00

workflows

fix: keep the review document outside the tree the reviewer mutates

2026-08-21 10:32:21 +03:00