mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Codex
b542f44bd6
CODE-REVIEW-295-r1, both Medium findings: M1 — _preflightDiagnostics hashed this._serverCfg, the saved config a space export would reproduce anyway. The hash now comes from the candidate the preflight actually judged: the report path passes r.config / d.config and the copy button reads the dialog's own candidate. The smoke no longer masks the difference — its dialog carries a candidate whose geometry differs from the saved config, and swapping the two must change the reported hash. M2 — the inline clipboard fallback survived dialog close and reopen, so a later refusal could hand the previous refusal's JSON to a bug report. The field now dies with its dialog: reset on open (_previewAlignDialog) and on every close path (escape, mode reset, successful apply, hp-close, cancel). Both regressions are pinned by execution: reverting either fix turns the extended smoke red (fingerprintTracksCandidate / fallbackClearedOnClose), and two new gate mutants keep it that way. Issue: #295 User-Visible: no