mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Claude
9a3af808d9
Code review r1 was right that AC5's evidence was empty: the smoke never forced a settled render during a gesture, so the settled copy of `.hp-editor-only-layer` was empty at every point it looked, and `groups() === 1` held whether the copy was hidden or not. Measuring the case the reviewer named turned up more than a weak assertion. Ownership of the layer alternates on its own — every settled render ends in `updated()` → `_commitLiveEditor()`, which empties the live root — so a settled render mid-gesture takes the guides back and draws them itself, from the same live `_alignPoint`. That much needs no suppression. But the copy it leaves behind stays in the settled scene, and the NEXT live paint adds a second one: measured two `.alignline` on one alignment, the settled one a grid step behind the marker. So the suppression stays, and now it stays with a witness. The smoke counts what is visible, not what is in the DOM: the hidden copy is still a node, and counting nodes is how this check could have looked green while showing the user two lines. Its device scenario now drives the whole handover — force an unrelated settled render mid-drag (`_hdrH`, the same header-height observer that masked the defect in the S2 measurements), assert the render actually happened, that the layer went back to the settled scene with the live point on it, and that one real move later the live painter owns it again — exactly one visible guide at every step. Mutant `live-editor-keeps-the-settled-guides-visible` puts the suppression back under the plan branch, as it was before this issue, and the smoke goes red on `nextMoveTakesTheLayerBack`. Issue: #521 User-Visible: no
146 lines
4.6 KiB
JSON
146 lines
4.6 KiB
JSON
{
|
|
"version": 2,
|
|
"fixture": "synthetic-only",
|
|
"chromium": "151.0.7922.34",
|
|
"oxipng": "oxipng 10.2.0",
|
|
"sourceFingerprint": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"captureScriptSha256": "9e4b0ae533407fe003a129078aec020f2c83d67cdb6fc6da696ce3d829beaeb5",
|
|
"command": "npm run build && node demo/docs/capture.mjs",
|
|
"scenarios": {
|
|
"view-desktop": {
|
|
"file": "01-view-desktop.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "76c35a87810e3dc6890bda7b43da133f57d8860031204a62cda7115c15950090"
|
|
},
|
|
"view-touch": {
|
|
"file": "02-view-touch.png",
|
|
"viewport": {
|
|
"width": 390,
|
|
"height": 760
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "795585acb09488236ebb8028a7fcbd918404c5fe01560bb9b4559de13d441625"
|
|
},
|
|
"space-create": {
|
|
"file": "03-space-create.png",
|
|
"viewport": {
|
|
"width": 900,
|
|
"height": 850
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "9f0970de09772674c3156b9fc5b2d49de0ceb22be11ecf8b136047d37d100a84"
|
|
},
|
|
"room-contour-close": {
|
|
"file": "04-room-contour-close.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "0c354a79f9c3660788b6c5e889a27b6bd78b1f209dc0eef6bb43e2c1344028c4"
|
|
},
|
|
"plan-context-tray": {
|
|
"file": "05-plan-context-tray.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "64169c543291bc4df806dcf8ff484b42c8ea55eb343323d945344e0e28f2ce97"
|
|
},
|
|
"device-editor": {
|
|
"file": "06-device-editor.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 1100
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "3c8703175605fcf0387d654cd30783ecfd33e21743e70b45190a5ae1a8d355c2"
|
|
},
|
|
"device-display-preview": {
|
|
"file": "06-device-display-preview.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 1100
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "5d6193202102f5e6d85567f1111fa105895b933979fbf369c6ba0b1029deb823"
|
|
},
|
|
"background-editor": {
|
|
"file": "07-background-editor.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "375900a29aa62632883ede6727b7dbb8b48cabe9d7d0e16425f9779c837f3dd9"
|
|
},
|
|
"room-card": {
|
|
"file": "08-room-card.png",
|
|
"viewport": {
|
|
"width": 1180,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "3d85424676c823ddca3fa7dab3cce089b6030e48c05d16d2d48d922c66c0cbd2"
|
|
},
|
|
"device-info": {
|
|
"file": "09-device-info.png",
|
|
"viewport": {
|
|
"width": 1000,
|
|
"height": 900
|
|
},
|
|
"theme": "dark",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "ac962820f8e1c5cb5b042d39b18dc95905fa840cb2d4749060d991be4f6977c2"
|
|
},
|
|
"pdf-export": {
|
|
"file": "10-pdf-export.png",
|
|
"viewport": {
|
|
"width": 900,
|
|
"height": 760
|
|
},
|
|
"theme": "light",
|
|
"language": "en",
|
|
"sourceSha256": "602ce9bcfdc4961cbd4b231bb988f3763f73cfa312932596cd151e43d85c0c6a",
|
|
"imageSha256": "4537692fd57a3ed95528eddd748eee5cb6e456ffab7cc49169853d62459252cd"
|
|
}
|
|
},
|
|
"acceptedOn": "linux",
|
|
"acceptance": {
|
|
"declared": [
|
|
"view-desktop",
|
|
"view-touch",
|
|
"device-info",
|
|
"pdf-export"
|
|
],
|
|
"witnesses": 7,
|
|
"floor": 2,
|
|
"lastWriteWasFingerprintOnly": true,
|
|
"identicalPixels": true
|
|
}
|
|
}
|