mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Codex
a8aeecc32c
Review CODE-REVIEW-220-r1. H1: markersNeedingPlacement decided who depends on the order by reading marker.area alone, while resolveExplicitMarkerPlacement reads `marker.area || <area of the HA device>`. The ordinary marker — bind an HA device, store neither field — is anchored by the registry and never depended on the order, yet it was being written a space it never asked for. Dormant today, and the day that HA area changes it moves the marker to whatever space used to be first. The resolver now asks for the area actually in force. M1: a mouse released past the panel left the gesture stuck, swallowing the next click. Pointer capture is the usual answer and is now taken, but it is not a guarantee — the browser grants it only for a live pointer. The window listener is what actually closes the gesture. M2: the fifth mutant from the spec is registered, plus a sixth for the stuck drag above. Writing the smoke for M1 turned up why the first attempt passed against broken code: synthetic PointerEvents default to composed:false and never leave the shadow root, so nothing outside the panel could ever hear them. Real pointer events are composed; the smoke now says so. Issue: #220 User-Visible: no