mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-29 03:09:36 +00:00
Claudeandclaude[bot]
063de0eef4
The sidebar page could serve a previous card for hours. It imported the card through the stable facade, `./houseplan-card.js` — a relative specifier, and relative resolution does not inherit a query. A dashboard reaches the same file as `houseplan-card.js?v=1.74.0`, so an upgrade changes its URL and the browser must refetch. The panel always asked for the same address, and entries are served with no Cache-Control at all — only ETag and Last-Modified — so the browser applies heuristic freshness and may answer from cache without asking. A stale 1164-byte loader names a stale chunk, chunks are immutable for a year, and the panel then ran a previous card against the current backend without a single error. The version banner was telling the truth; reloading could not help, because the address never changed. Rollup already emits the right edge: the panel's side-effect import points straight at the shared implementation. The rewrite in entryFallbackPlugin replaced it with the facade for a fallback that the hashed name gives anyway — and better: a chunk the manifest no longer serves now raises the panel's own "House Plan was updated" notice instead of silently working on old code. Two #486 assertions change meaning and are rewritten, not adjusted: the panel no longer routes through the facade, and its initial graph no longer contains it. The invariant they defended — the panel reuses the exact card graph, never a second copy — is now stated over the implementation, and a new test pins that no built entry reaches the card by an address without a version. Issue: #535 User-Visible: yes
112 lines
4.3 KiB
JavaScript
112 lines
4.3 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import { spawnSync } from 'node:child_process';
|
|
import { createHash } from 'node:crypto';
|
|
import {
|
|
mkdirSync, mkdtempSync, rmSync, unlinkSync, writeFileSync,
|
|
} from 'node:fs';
|
|
import { dirname, join } from 'node:path';
|
|
import { tmpdir } from 'node:os';
|
|
import test from 'node:test';
|
|
|
|
import { verifyHouseplanZip } from '../scripts/verify-houseplan-zip.mjs';
|
|
|
|
const sha256 = (contents) => createHash('sha256').update(contents).digest('hex');
|
|
|
|
const git = (root, args) => {
|
|
const result = spawnSync('git', args, { cwd: root, encoding: 'utf8' });
|
|
assert.equal(result.status, 0, result.stderr || result.stdout);
|
|
};
|
|
|
|
const write = (root, name, contents) => {
|
|
const path = join(root, name);
|
|
mkdirSync(dirname(path), { recursive: true });
|
|
writeFileSync(path, contents);
|
|
};
|
|
|
|
test('#486 HACS zip contains both entries and rejects stale managed roots', () => {
|
|
const root = mkdtempSync(join(tmpdir(), 'houseplan-zip-panel-'));
|
|
const component = join(root, 'component');
|
|
const frontend = join(component, 'frontend');
|
|
const zip = join(root, 'houseplan.zip');
|
|
try {
|
|
const payload = new Map([
|
|
['houseplan-card.js', 'card entry'],
|
|
['houseplan-panel.js', 'panel entry'],
|
|
['houseplan-assets/card-HASH.js', 'shared card'],
|
|
]);
|
|
for (const [name, contents] of payload) write(frontend, name, contents);
|
|
const files = [...payload].map(([path, contents]) => ({
|
|
path,
|
|
sha256: sha256(contents),
|
|
rawBytes: Buffer.byteLength(contents),
|
|
gzipBytes: path === 'houseplan-card.js' ? 5 : path === 'houseplan-panel.js' ? 3 : 7,
|
|
isEntry: path === 'houseplan-card.js' || path === 'houseplan-panel.js',
|
|
imports: path === 'houseplan-panel.js'
|
|
? ['houseplan-assets/card-HASH.js']
|
|
: path === 'houseplan-card.js' ? ['houseplan-assets/card-HASH.js'] : [],
|
|
dynamicImports: [],
|
|
}));
|
|
write(frontend, 'houseplan-assets.json', `${JSON.stringify({
|
|
schema: 1,
|
|
fingerprint: 'f'.repeat(64),
|
|
entry: 'houseplan-card.js',
|
|
panelEntry: 'houseplan-panel.js',
|
|
initialViewFiles: ['houseplan-assets/card-HASH.js', 'houseplan-card.js'],
|
|
initialViewGzipBytes: 12,
|
|
initialPanelFiles: [
|
|
'houseplan-assets/card-HASH.js', 'houseplan-panel.js',
|
|
],
|
|
initialPanelGzipBytes: 10,
|
|
initialPanelOnlyFiles: ['houseplan-panel.js'],
|
|
initialPanelOnlyGzipBytes: 3,
|
|
files,
|
|
})}\n`);
|
|
write(component, 'manifest.json', '{"version":"1.2.3"}\n');
|
|
|
|
git(root, ['init', '-q']);
|
|
git(root, ['config', 'user.name', 'House Plan test']);
|
|
git(root, ['config', 'user.email', 'test@example.invalid']);
|
|
git(root, ['config', 'core.autocrlf', 'false']);
|
|
git(root, ['add', 'component']);
|
|
git(root, ['commit', '-qm', 'fixture']);
|
|
git(root, ['archive', '--format=zip', `--output=${zip}`, 'HEAD:component']);
|
|
assert.deepEqual(verifyHouseplanZip(zip, frontend, '1.2.3'), {
|
|
version: '1.2.3', files: 3,
|
|
});
|
|
|
|
unlinkSync(join(frontend, 'houseplan-panel.js'));
|
|
git(root, ['add', '-A', 'component']);
|
|
git(root, ['commit', '-qm', 'missing panel']);
|
|
unlinkSync(zip);
|
|
git(root, ['archive', '--format=zip', `--output=${zip}`, 'HEAD:component']);
|
|
assert.throws(
|
|
() => verifyHouseplanZip(zip, frontend, '1.2.3'),
|
|
/missing frontend\/houseplan-panel\.js/,
|
|
);
|
|
|
|
write(frontend, 'houseplan-panel.js', 'panel entry');
|
|
write(frontend, 'houseplan-obsolete.js', 'stale root entry');
|
|
git(root, ['add', '-A', 'component']);
|
|
git(root, ['commit', '-qm', 'orphan']);
|
|
unlinkSync(zip);
|
|
git(root, ['archive', '--format=zip', `--output=${zip}`, 'HEAD:component']);
|
|
assert.throws(
|
|
() => verifyHouseplanZip(zip, frontend, '1.2.3'),
|
|
/orphan bundle asset: frontend\/houseplan-obsolete\.js/,
|
|
);
|
|
|
|
unlinkSync(join(frontend, 'houseplan-obsolete.js'));
|
|
write(frontend, 'houseplan-panel.js', 'tampered panel entry');
|
|
git(root, ['add', '-A', 'component']);
|
|
git(root, ['commit', '-qm', 'tamper']);
|
|
unlinkSync(zip);
|
|
git(root, ['archive', '--format=zip', `--output=${zip}`, 'HEAD:component']);
|
|
assert.throws(
|
|
() => verifyHouseplanZip(zip, frontend, '1.2.3'),
|
|
/frontend hash mismatch: houseplan-panel\.js/,
|
|
);
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true });
|
|
}
|
|
});
|