mirror of
https://github.com/Matysh/houseplan-card
synced 2026-09-30 11:49:16 +00:00
Matysh
d1be6891b2
Validate / hacs (push) Failing after 55s
Validate / hassfest (push) Failing after 13s
Validate / frontend (push) Successful in 6m16s
Validate / backend (push) Failing after 8m39s
Validate / provenance (push) Successful in 37s
Validate / golden (push) Failing after 8m4s
Validate / smoke (push) Failing after 27m15s
Validate / performance_smoke (push) Failing after 14m5s
Full Performance / performance (push) Failing after 1h15m11s
A green code review whose merge conflicted used to leave the label where it was. That is a dead end: the author waits for the label to change, so it polled thirty times and reported the limit as exhausted — on a task the reviewer had already passed. The verdict existed and nobody could act on it. The merge step no longer fails the job. It reports whether it merged, and a green review that did not merge sends the task back to S6-in-progress, because the work did return to the author — a rebase rather than a code fix, and the comment says so and says the verdict still stands. The invariant is now stronger and worth stating plainly: after a review run the label always changes. A pipeline whose state can stall silently is worse than one that reports the wrong state loudly. Issue: #114 User-Visible: no