houseplan-card/tests_backend/test_ha_websocket.py

"""WebSocket API tests (CI): layout ops, config rev conflict, not_ready gate."""
import copy
import json
from pathlib import Path

import pytest


@pytest.fixture(autouse=True)
def _enable_custom_integrations(enable_custom_integrations):
    """Allow loading custom_components in the test hass."""
    yield

from homeassistant.core import HomeAssistant
from pytest_homeassistant_custom_component.common import MockConfigEntry
from pytest_homeassistant_custom_component.typing import WebSocketGenerator

from custom_components.houseplan.const import CONF_ADMIN_ONLY, DOMAIN
from custom_components.houseplan.websocket_api import (
    _space_delete_candidate, _space_marker_dependencies,
)


async def _setup(hass: HomeAssistant) -> MockConfigEntry:
    entry = MockConfigEntry(domain=DOMAIN, title="House Plan", data={}, options={})
    entry.add_to_hass(hass)
    assert await hass.config_entries.async_setup(entry.entry_id)
    await hass.async_block_till_done()
    return entry


def _space(space_id: str, room_id: str) -> dict:
    return {
        "id": space_id, "title": space_id, "view_box": [0, 0, 1, 1],
        "rooms": [{
            "id": room_id, "name": room_id,
            "poly": [[0, 0], [1, 0], [1, 1], [0, 1]],
        }],
        "plan_url": None,
    }


def test_issue_244_space_delete_dependency_and_tombstone_candidate() -> None:
    config = {
        "spaces": [_space("f1", "r1"), _space("f2", "r2")],
        "markers": [
            {"id": "all", "binding": "virtual", "space": "f1", "room_id": "r1"},
            {"id": "position", "binding": "virtual", "space": "f2"},
            {
                "id": "removed", "binding": "entity:light.old", "removed": True,
                "space": "f1", "room_id": "r1", "name": "Kept",
            },
        ],
        "settings": {},
    }
    layout = {"all": {"s": "f1"}, "position": {"s": "f1"}, "removed": {"s": "f1"}}
    assert _space_marker_dependencies(config, layout, "f1") == ["all", "position"]

    config["markers"] = [config["markers"][2]]
    candidate, candidate_layout, dependencies, removed_layout = _space_delete_candidate(
        config, layout, "f1",
    )
    assert dependencies == []
    assert [item["id"] for item in candidate["spaces"]] == ["f2"]
    assert candidate["markers"][0] == {
        "id": "removed", "binding": "entity:light.old", "removed": True, "name": "Kept",
    }
    assert candidate_layout == {}
    assert removed_layout == 3
    assert config["markers"][0]["space"] == "f1"


def test_issue_244_last_occupied_space_candidate_detaches_all_affected_markers() -> None:
    config = {
        "spaces": [_space("only", "room-only")],
        "markers": [
            {
                "id": "direct", "binding": "virtual", "space": "only",
                "room_id": "room-only", "name": "Kept", "icon": "mdi:lightbulb",
            },
            {
                "id": "position", "binding": "virtual", "name": "Position",
            },
            {
                "id": "removed", "binding": "entity:light.old", "removed": True,
                "space": "only", "room_id": "room-only", "name": "Tombstone",
            },
            {
                "id": "unrelated", "binding": "virtual", "space": "legacy",
                "name": "Unrelated",
            },
        ],
        "settings": {},
    }
    layout = {
        "direct": {"s": "only", "x": 0.1, "y": 0.2},
        "position": {"s": "only", "x": 0.3, "y": 0.4},
        "rl_room-only": {"s": "only", "x": 0.5, "y": 0.6},
    }

    candidate, candidate_layout, dependencies, removed_layout = _space_delete_candidate(
        config, layout, "only",
    )

    assert dependencies == ["direct", "position"]
    assert candidate["spaces"] == []
    assert candidate_layout == {}
    assert removed_layout == 3
    by_id = {marker["id"]: marker for marker in candidate["markers"]}
    for marker_id in ("direct", "position", "removed"):
        assert "space" not in by_id[marker_id]
        assert "room_id" not in by_id[marker_id]
    assert by_id["direct"]["icon"] == "mdi:lightbulb"
    assert by_id["unrelated"]["space"] == "legacy"
    assert config["markers"][0]["space"] == "only"
    assert layout["direct"]["s"] == "only"


async def test_issue_244_space_delete_is_authoritative_and_revision_guarded(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    config = {
        "spaces": [_space("f1", "r1"), _space("f2", "r2")],
        "markers": [{"id": "device", "binding": "virtual", "space": "f1"}],
        "settings": {},
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": config, "expected_rev": 0,
    })
    config_set = await client.receive_json()
    assert config_set["success"]
    await client.send_json_auto_id({
        "type": "houseplan/layout/set", "layout": {
            "device": {"s": "f1", "x": 0.2, "y": 0.3},
            "rl_r1": {"s": "f1", "x": 0.5, "y": 0.5},
        },
    })
    layout_set = await client.receive_json()
    assert layout_set["success"]

    await client.send_json_auto_id({
        "type": "houseplan/space/delete", "space_id": "f1",
        "expected_config_rev": config_set["result"]["rev"],
        "expected_layout_rev": layout_set["result"]["rev"],
    })
    blocked = await client.receive_json()
    assert not blocked["success"] and blocked["error"]["code"] == "space_in_use"

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    unchanged_config = await client.receive_json()
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    unchanged_layout = await client.receive_json()
    assert unchanged_config["result"]["rev"] == config_set["result"]["rev"]
    assert unchanged_layout["result"]["rev"] == layout_set["result"]["rev"]

    config["markers"] = [{
        "id": "device", "binding": "virtual", "space": "f1", "removed": True,
        "name": "Kept tombstone",
    }]
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": config,
        "expected_rev": unchanged_config["result"]["rev"],
    })
    config_set = await client.receive_json()
    assert config_set["success"]
    await client.send_json_auto_id({
        "type": "houseplan/space/delete", "space_id": "f1",
        "expected_config_rev": config_set["result"]["rev"],
        "expected_layout_rev": unchanged_layout["result"]["rev"],
    })
    deleted = await client.receive_json()
    assert deleted["success"]
    assert deleted["result"]["removed_layout"] == 2

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    final_config = (await client.receive_json())["result"]
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    final_layout = (await client.receive_json())["result"]
    assert [item["id"] for item in final_config["config"]["spaces"]] == ["f2"]
    assert final_config["config"]["markers"][0] == {
        "id": "device", "binding": "virtual", "removed": True,
        "name": "Kept tombstone",
    }
    assert final_layout["layout"] == {}


async def test_issue_244_last_occupied_space_delete_preserves_marker_records(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    config = {
        "spaces": [_space("only", "room-only")],
        "markers": [{
            "id": "device", "binding": "virtual", "space": "only",
            "room_id": "room-only", "name": "Kept", "icon": "mdi:lightbulb",
        }],
        "settings": {},
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": config, "expected_rev": 0,
    })
    config_set = await client.receive_json()
    assert config_set["success"]
    await client.send_json_auto_id({
        "type": "houseplan/layout/set",
        "layout": {"device": {"s": "only", "x": 0.2, "y": 0.3}},
    })
    layout_set = await client.receive_json()
    assert layout_set["success"]

    await client.send_json_auto_id({
        "type": "houseplan/space/delete", "space_id": "only",
        "expected_config_rev": config_set["result"]["rev"],
        "expected_layout_rev": layout_set["result"]["rev"],
    })
    deleted = await client.receive_json()
    assert deleted["success"]

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    final_config = (await client.receive_json())["result"]["config"]
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    final_layout = (await client.receive_json())["result"]["layout"]
    assert final_config["spaces"] == []
    assert final_config["markers"] == [{
        "id": "device", "binding": "virtual", "name": "Kept",
        "icon": "mdi:lightbulb",
    }]
    assert final_layout == {}


async def test_layout_roundtrip(hass: HomeAssistant, hass_ws_client: WebSocketGenerator) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    resp = await client.receive_json()
    assert resp["success"] and resp["result"]["layout"] == {}

    await client.send_json_auto_id(
        {"type": "houseplan/layout/set", "layout": {"dev1": {"s": "f1", "x": 0.5, "y": 0.5}}}
    )
    assert (await client.receive_json())["success"]

    await client.send_json_auto_id(
        {"type": "houseplan/layout/update", "device_id": "dev2", "pos": {"s": "f1", "x": 0.1, "y": 0.2}}
    )
    assert (await client.receive_json())["success"]

    await client.send_json_auto_id({"type": "houseplan/layout/delete", "device_id": "dev1"})
    assert (await client.receive_json())["success"]

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    resp = await client.receive_json()
    assert set(resp["result"]["layout"]) == {"dev2"}


async def test_deleted_marker_rejects_a_stale_layout_update(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """A late drag from another tab must not resurrect a deleted position."""
    await _setup(hass)
    client = await hass_ws_client(hass)
    cfg = {
        "spaces": [],
        "markers": [
            {"id": "dev1", "binding": "device:dev1", "removed": True},
            {"id": "v_live", "binding": "virtual", "name": "Still here"},
            {"id": "v_real", "binding": "device:real-device"},
        ],
        "settings": {},
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": cfg, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]

    await client.send_json_auto_id({
        "type": "houseplan/layout/update",
        "device_id": "dev1",
        "pos": {"s": "f1", "x": 0.1, "y": 0.2},
    })
    ignored = await client.receive_json()
    assert ignored["success"] and ignored["result"]["ignored"] == "removed"

    await client.send_json_auto_id({
        "type": "houseplan/layout/update",
        "device_id": "v_deleted",
        "pos": {"s": "f1", "x": 0.3, "y": 0.4},
    })
    ignored_virtual = await client.receive_json()
    assert ignored_virtual["success"]
    assert ignored_virtual["result"]["ignored"] == "missing_virtual"

    # `v_` is only the historical virtual naming convention. An explicit
    # non-virtual marker with that prefix must remain positionable.
    await client.send_json_auto_id({
        "type": "houseplan/layout/update",
        "device_id": "v_real",
        "pos": {"s": "f1", "x": 0.2, "y": 0.25},
    })
    real = await client.receive_json()
    assert real["success"] and "ignored" not in real["result"]

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    assert (await client.receive_json())["result"]["layout"] == {
        "v_real": {"s": "f1", "x": 0.2, "y": 0.25},
    }

    # The compatibility wholesale endpoint applies the same filter.
    await client.send_json_auto_id({
        "type": "houseplan/layout/set",
        "layout": {
            "dev1": {"s": "f1", "x": 0.1, "y": 0.2},
            "v_deleted": {"s": "f1", "x": 0.3, "y": 0.4},
            "v_live": {"s": "f1", "x": 0.4, "y": 0.5},
            "v_real": {"s": "f1", "x": 0.45, "y": 0.55},
            "rl_r1": {"s": "f1", "x": 0.35, "y": 0.45},
            "ordinary_auto_device": {"s": "f1", "x": 0.5, "y": 0.6},
        },
        "expected_rev": 1,
    })
    assert (await client.receive_json())["success"]
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    assert (await client.receive_json())["result"]["layout"] == {
        "v_live": {"s": "f1", "x": 0.4, "y": 0.5},
        "v_real": {"s": "f1", "x": 0.45, "y": 0.55},
        "rl_r1": {"s": "f1", "x": 0.35, "y": 0.45},
        "ordinary_auto_device": {"s": "f1", "x": 0.5, "y": 0.6},
    }


async def test_trail_delete_clears_the_server_book(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    await _setup(hass)
    recorder = hass.data[DOMAIN]["trail_recorder"]
    recorder.book.data["m1"] = {"current": {"points": [[1, 2]]}}
    client = await hass_ws_client(hass)
    await client.send_json_auto_id({"type": "houseplan/trail/delete", "marker_id": "m1"})
    response = await client.receive_json()
    assert response["success"] and response["result"]["removed"] is True
    assert "m1" not in recorder.book.data


async def test_trail_delete_rejects_non_admin_without_mutation(
    hass: HomeAssistant,
    hass_ws_client: WebSocketGenerator,
    hass_read_only_access_token: str,
) -> None:
    await _setup(hass)
    recorder = hass.data[DOMAIN]["trail_recorder"]
    recorder.book.data["m1"] = {"current": {"points": [[1, 2]]}}
    # The current HA harness authenticates websocket clients by access token;
    # older releases accepted a `user=` shortcut which no longer exists.
    client = await hass_ws_client(hass, access_token=hass_read_only_access_token)
    await client.send_json_auto_id({"type": "houseplan/trail/delete", "marker_id": "m1"})
    response = await client.receive_json()
    assert not response["success"] and response["error"]["code"] == "unauthorized"
    assert "m1" in recorder.book.data


async def test_config_rev_conflict(hass: HomeAssistant, hass_ws_client: WebSocketGenerator) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    cfg = {"spaces": [], "markers": [], "settings": {}}

    await client.send_json_auto_id({"type": "houseplan/config/set", "config": cfg, "expected_rev": 0})
    resp = await client.receive_json()
    assert resp["success"] and resp["result"]["rev"] == 1

    # stale expected_rev must be rejected with `conflict`
    await client.send_json_auto_id({"type": "houseplan/config/set", "config": cfg, "expected_rev": 0})
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "conflict"

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    resp = await client.receive_json()
    assert resp["result"]["rev"] == 1


async def test_canonical_rewrites_are_noops_without_events_or_undo_loss(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """#224: a read/write echo must not manufacture another edit."""
    from custom_components.houseplan.store import get_data

    await _setup(hass)
    client = await hass_ws_client(hass)
    config_events = []
    layout_events = []
    hass.bus.async_listen(
        "houseplan_config_updated", lambda event: config_events.append(event.data)
    )
    hass.bus.async_listen(
        "houseplan_layout_updated", lambda event: layout_events.append(event.data)
    )

    noisy_config = {
        "spaces": [{
            "id": "floor",
            "title": "Floor",
            "view_box": [0, 0, 1, 1],
            "rooms": [{
                "id": "room",
                "name": "Room",
                "poly": [[0.1234567896, 0], [0.5, 0], [0.5, 0.5]],
            }],
        }],
        "markers": [],
        "settings": {},
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": noisy_config, "expected_rev": 0,
    })
    first = await client.receive_json()
    assert first["success"] and first["result"]["rev"] == 1
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    canonical_config = (await client.receive_json())["result"]["config"]
    assert canonical_config["spaces"][0]["rooms"][0]["poly"][0][0] == 0.12345679

    runtime = get_data(hass)
    assert runtime is not None
    layout_data = await runtime.store.async_load() or {}
    layout_data["optimize_backup"] = {"sentinel": True}
    await runtime.store.async_save(layout_data)

    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": canonical_config, "expected_rev": 1,
    })
    noop = await client.receive_json()
    assert noop["success"] and noop["result"]["rev"] == 1
    assert len(config_events) == 1
    assert "optimize_backup" in (await runtime.store.async_load())

    # CAS remains authoritative even when the body is otherwise identical.
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": canonical_config, "expected_rev": 0,
    })
    stale = await client.receive_json()
    assert not stale["success"] and stale["error"]["code"] == "conflict"

    noisy_layout = {
        "lamp": {"s": "floor", "x": 0.1234567896, "y": -0.1234567896}
    }
    await client.send_json_auto_id({
        "type": "houseplan/layout/set", "layout": noisy_layout, "expected_rev": 0,
    })
    first_layout = await client.receive_json()
    assert first_layout["success"] and first_layout["result"]["rev"] == 1
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    canonical_layout = (await client.receive_json())["result"]["layout"]
    assert canonical_layout["lamp"]["x"] == 0.12345679

    layout_data = await runtime.store.async_load() or {}
    layout_data["optimize_backup"] = {"sentinel": True}
    await runtime.store.async_save(layout_data)
    await client.send_json_auto_id({
        "type": "houseplan/layout/set",
        "layout": canonical_layout,
        "expected_rev": 1,
    })
    layout_noop = await client.receive_json()
    assert layout_noop["success"] and layout_noop["result"]["rev"] == 1

    await client.send_json_auto_id({
        "type": "houseplan/layout/update",
        "device_id": "lamp",
        "pos": canonical_layout["lamp"],
    })
    point_noop = await client.receive_json()
    assert point_noop["success"] and point_noop["result"]["rev"] == 1
    assert len(layout_events) == 1
    assert "optimize_backup" in (await runtime.store.async_load())


async def test_optimize_undo_restores_geometry_but_not_legacy_noisy_bits(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """#224 supersedes #223's invisible exact-bit Undo promise."""
    from custom_components.houseplan.store import get_data

    await _setup(hass)
    client = await hass_ws_client(hass)
    runtime = get_data(hass)
    assert runtime is not None
    noisy_config = {
        "spaces": [{
            "id": "floor",
            "title": "Floor",
            "view_box": [0, 0, 1, 1],
            "rooms": [{
                "id": "room",
                "name": "Room",
                "poly": [[0.1234567896, 0], [0.5, 0], [0.5, 0.5]],
            }],
        }],
        "markers": [],
        "settings": {},
    }
    noisy_layout = {
        "lamp": {"s": "floor", "x": -0.1234567896, "y": 0.5}
    }
    # Seed the pre-#224 store directly: public writers can no longer create it.
    await runtime.config_store.async_save({"config": noisy_config, "rev": 1})
    await runtime.store.async_save({"layout": noisy_layout, "rev": 1})

    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize",
        "config": noisy_config,
        "layout": noisy_layout,
        "expected_config_rev": 1,
        "expected_layout_rev": 1,
    })
    optimized = await client.receive_json()
    assert optimized["success"]
    stored_layout = await runtime.store.async_load()
    backup = stored_layout["optimize_backup"]
    assert backup["config"]["spaces"][0]["rooms"][0]["poly"][0][0] == 0.12345679
    assert backup["layout"]["lamp"]["x"] == -0.12345679

    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize_undo",
        "expected_config_rev": 2,
        "expected_layout_rev": 2,
    })
    undone = await client.receive_json()
    assert undone["success"] and undone["result"]["can_undo"] is False
    restored_config = (await runtime.config_store.async_load())["config"]
    restored_layout = (await runtime.store.async_load())["layout"]
    assert restored_config["spaces"][0]["rooms"][0]["poly"][0][0] == 0.12345679
    assert restored_layout["lamp"]["x"] == -0.12345679


async def test_plan_optimize_persists_exact_storage_roundtrip_target(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, monkeypatch
) -> None:
    """#248: intent, normal commit and reads expose one canonical pair."""
    from custom_components.houseplan.store import get_data

    fixture = json.loads((
        Path(__file__).parents[1]
        / "test"
        / "fixtures"
        / "optimize-storage-roundtrip.json"
    ).read_text(encoding="utf-8"))
    source = fixture["input"]
    expected = fixture["expected"]

    await _setup(hass)
    client = await hass_ws_client(hass)
    runtime = get_data(hass)
    assert runtime is not None

    layout_writes = []
    real_layout_save = runtime.store.async_save

    async def capture_layout_write(value: dict) -> None:
        layout_writes.append(copy.deepcopy(value))
        await real_layout_save(value)

    monkeypatch.setattr(runtime.store, "async_save", capture_layout_write)
    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize",
        "config": source["config"],
        "layout": source["layout"],
        "expected_config_rev": 0,
        "expected_layout_rev": 0,
    })
    response = await client.receive_json()
    assert response["success"]
    assert response["result"]["config_rev"] == 1
    assert response["result"]["layout_rev"] == 1

    intent_write = next(
        item for item in layout_writes if "optimize_pending" in item
    )
    pending = intent_write["optimize_pending"]
    final_config = await runtime.config_store.async_load()
    final_layout = await runtime.store.async_load()

    assert pending["config"] == expected["config"]
    assert pending["layout"] == expected["layout"]
    assert final_config["config"] == expected["config"]
    assert final_layout["layout"] == expected["layout"]
    assert "optimize_pending" not in final_layout
    assert json.dumps(pending["config"], sort_keys=True, separators=(",", ":")) == \
        json.dumps(final_config["config"], sort_keys=True, separators=(",", ":"))
    assert json.dumps(pending["layout"], sort_keys=True, separators=(",", ":")) == \
        json.dumps(final_layout["layout"], sort_keys=True, separators=(",", ":"))


async def test_config_set_validates_new_marker_light_links(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    base = {
        "spaces": [], "settings": {},
        "markers": [{"id": "lamp", "binding": "virtual", "is_light": True}],
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": base, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]

    invalid = {
        **base,
        "markers": [*base["markers"], {
            "id": "controller", "binding": "virtual",
            "controls": ["marker:missing"],
        }],
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": invalid, "expected_rev": 1,
    })
    response = await client.receive_json()
    assert not response["success"]
    assert response["error"]["code"] == "marker_control_missing"

    # Rejection is atomic: the failed graph never increments the revision.
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    stored = (await client.receive_json())["result"]
    assert stored["rev"] == 1 and stored["config"] == base


async def test_plan_optimize_rejects_new_marker_light_cycle(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    base = {
        "spaces": [], "settings": {},
        "markers": [
            {"id": "a", "binding": "virtual", "is_light": True},
            {"id": "b", "binding": "virtual", "is_light": True},
        ],
    }
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": base, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]
    cyclic = {
        **base,
        "markers": [
            {**base["markers"][0], "controls": ["marker:b"]},
            {**base["markers"][1], "controls": ["marker:a"]},
        ],
    }
    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize", "config": cyclic, "layout": {},
        "expected_config_rev": 1, "expected_layout_rev": 0,
    })
    response = await client.receive_json()
    assert not response["success"]
    assert response["error"]["code"] == "marker_control_cycle"

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    stored = (await client.receive_json())["result"]
    assert stored["rev"] == 1 and stored["config"] == base


@pytest.mark.parametrize("endpoint,field,value", [
    ("houseplan/config/set", "lock", "lock.private"),
    ("houseplan/plan/optimize", "flip_h", False),
])
async def test_config_writers_reject_invalid_passage_atomically(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator,
    endpoint: str, field: str, value: object,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    base = {"spaces": [], "markers": [], "settings": {}}
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": base, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]

    passage = {
        "id": "passage", "type": "passage", "x": 0.5, "y": 0.5,
        "angle": 0, "length": 0.09, field: value,
    }
    invalid = {"spaces": [{
        "id": "ground", "title": "Ground", "view_box": [0, 0, 1, 1],
        "rooms": [], "openings": [passage],
    }], "markers": [], "settings": {}}
    message = {"type": endpoint, "config": invalid}
    if endpoint == "houseplan/config/set":
        message["expected_rev"] = 1
    else:
        message.update({
            "layout": {}, "expected_config_rev": 1, "expected_layout_rev": 0,
        })
    await client.send_json_auto_id(message)
    response = await client.receive_json()
    assert not response["success"]
    assert response["error"]["code"] == "invalid_passage_fields"
    assert "lock.private" not in response["error"]["message"]

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    stored = (await client.receive_json())["result"]
    assert stored["rev"] == 1 and stored["config"] == base
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    layout = (await client.receive_json())["result"]
    assert layout["rev"] == 0 and layout["layout"] == {}


@pytest.mark.parametrize("endpoint", [
    "houseplan/config/set",
    "houseplan/plan/optimize",
])
async def test_config_writers_reject_partition_opening_without_jamb_atomically(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, endpoint: str,
) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)
    base = {"spaces": [], "markers": [], "settings": {}}
    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": base, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]

    invalid = {"spaces": [{
        "id": "ground", "title": "Ground", "view_box": [0, 0, 1, 1],
        "rooms": [],
        "partitions": [{"id": "wall", "a": [0, 0], "b": [1, 0], "cm": 15}],
        "openings": [{
            "id": "door", "type": "door", "x": 0.1, "y": 0,
            "angle": 0, "length": 0.2,
            "host": {"kind": "partition", "id": "wall", "t": 0.1},
        }],
    }], "markers": [], "settings": {}}
    message = {"type": endpoint, "config": invalid}
    if endpoint == "houseplan/config/set":
        message["expected_rev"] = 1
    else:
        message.update({
            "layout": {}, "expected_config_rev": 1, "expected_layout_rev": 0,
        })
    await client.send_json_auto_id(message)
    response = await client.receive_json()
    assert not response["success"]
    assert response["error"]["code"] == "invalid_partition_opening_jamb_margin"
    assert "space=ground" in response["error"]["message"]
    assert "opening=door" in response["error"]["message"]
    assert "margin_cm=7.5" in response["error"]["message"]

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    stored = (await client.receive_json())["result"]
    assert stored["rev"] == 1 and stored["config"] == base
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    layout = (await client.receive_json())["result"]
    assert layout["rev"] == 0 and layout["layout"] == {}


async def test_plan_optimize_pair_and_one_deep_undo_survives_geometry_repair(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """Maintenance preserves the one-deep snapshot and its revision guard."""
    await _setup(hass)
    client = await hass_ws_client(hass)
    original = {"spaces": [], "markers": [], "settings": {}}
    original_layout = {"dev": {"s": "f1", "x": 0.1, "y": 0.2}}

    await client.send_json_auto_id({
        "type": "houseplan/config/set", "config": original, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]
    await client.send_json_auto_id({
        "type": "houseplan/layout/set", "layout": original_layout, "expected_rev": 0,
    })
    assert (await client.receive_json())["success"]

    optimized = {**original, "model_version": 1}
    optimized_layout = {"dev": {"s": "f1", "x": 0.125, "y": 0.25}}
    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize",
        "config": optimized,
        "layout": optimized_layout,
        "expected_config_rev": 1,
        "expected_layout_rev": 1,
    })
    resp = await client.receive_json()
    assert resp["success"]
    assert resp["result"]["config_rev"] == 2
    assert resp["result"]["layout_rev"] == 2
    assert resp["result"]["can_undo"] is True

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    assert (await client.receive_json())["result"]["can_optimize_undo"] is True

    # Explicit geometry maintenance must not silently consume the advertised
    # one-deep plan undo (#87).  It advances only the layout revision, so the
    # preserved snapshot must advance its freshness marker with it.
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "f1", "aspect": 2.0,
    })
    repaired = await client.receive_json()
    assert repaired["success"] and repaired["result"]["rev"] == 3
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    assert (await client.receive_json())["result"]["can_optimize_undo"] is True

    # Repair's own undo is maintenance as well and must carry the outer plan
    # snapshot forward instead of consuming it.
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "f1",
        "aspect": 2.0, "undo": True,
    })
    repaired_undo = await client.receive_json()
    assert repaired_undo["success"] and repaired_undo["result"]["rev"] == 4
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    assert (await client.receive_json())["result"]["can_optimize_undo"] is True

    # Re-apply repair so the final assertion covers Optimize Undo directly
    # after a geometry mutation, exactly as reported in #87.
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "f1", "aspect": 2.0,
    })
    repaired_again = await client.receive_json()
    assert repaired_again["success"] and repaired_again["result"]["rev"] == 5

    await client.send_json_auto_id({
        "type": "houseplan/plan/optimize_undo",
        "expected_config_rev": 2,
        "expected_layout_rev": 5,
    })
    resp = await client.receive_json()
    assert resp["success"] and resp["result"]["can_undo"] is False

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    cfg = (await client.receive_json())["result"]
    assert cfg["config"] == original
    assert cfg["can_optimize_undo"] is False
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    layout = (await client.receive_json())["result"]
    assert layout["layout"] == original_layout

    from custom_components.houseplan.store import get_data

    stored = await get_data(hass).store.async_load()
    assert "repair_backup" not in stored, (
        "full plan undo invalidates the nested repair undo"
    )


async def test_not_ready_without_entry(hass: HomeAssistant, hass_ws_client: WebSocketGenerator) -> None:
    """WS commands answer not_ready when the integration has no loaded entry."""
    # register only the WS commands, without an entry
    from custom_components.houseplan import websocket_api as hp_ws

    hp_ws.async_register(hass)
    client = await hass_ws_client(hass)
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "not_ready"


async def test_plan_set_validates(hass: HomeAssistant, hass_ws_client: WebSocketGenerator) -> None:
    await _setup(hass)
    client = await hass_ws_client(hass)

    await client.send_json_auto_id(
        {"type": "houseplan/plan/set", "space_id": "../evil", "ext": "png", "data": "aGk="}
    )
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "invalid_space_id"

    await client.send_json_auto_id(
        {"type": "houseplan/plan/set", "space_id": "s1", "ext": "png", "data": "%%%not-base64%%%"}
    )
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "invalid_data"

    await client.send_json_auto_id(
        {"type": "houseplan/plan/set", "space_id": "s1", "ext": "png", "data": "aGVsbG8="}
    )
    resp = await client.receive_json()
    url = resp["result"]["url"]
    assert resp["success"]
    # versioned name: "<space>.<token>.<ext>" (review R2-1)
    name = url.rsplit("/", 1)[-1]
    assert name.startswith("s1.") and name.endswith(".png") and len(name.split(".")) == 3


async def test_admin_check_fails_closed(hass, hass_ws_client):
    """audit B2/T4: with no config entry the policy is unknown — deny writes.

    This used to allow them: plan uploads slipped through during a reload.
    """
    from custom_components.houseplan import websocket_api as wsapi

    class _User:
        is_admin = False

    class _Conn:
        user = _User()

    # no entry at all → non-admin must be refused
    assert wsapi._check_write(hass, _Conn()) is False

    class _Admin:
        is_admin = True

    class _AdminConn:
        user = _Admin()

    assert wsapi._check_write(hass, _AdminConn()) is True


async def test_may_write_defaults_admin_only_when_option_missing(hass):
    """audit P0-4: empty options ⇒ admin-only (matches the card UI)."""
    from custom_components.houseplan.auth import may_write

    await _setup(hass)  # options={}

    class _User:
        is_admin = False

    class _Admin:
        is_admin = True

    # missing / unset key must not open writes to every household user
    assert may_write(hass, _User()) is False
    assert may_write(hass, _Admin()) is True


async def test_may_write_honours_explicit_admin_only_false(hass):
    """Household users may write only when the option is explicitly off."""
    from custom_components.houseplan.auth import may_write

    entry = MockConfigEntry(
        domain=DOMAIN, title="House Plan", data={}, options={CONF_ADMIN_ONLY: False}
    )
    entry.add_to_hass(hass)
    assert await hass.config_entries.async_setup(entry.entry_id)
    await hass.async_block_till_done()

    class _User:
        is_admin = False

    assert may_write(hass, _User()) is True


async def test_config_get_reports_can_write(hass: HomeAssistant, hass_ws_client: WebSocketGenerator) -> None:
    """audit P0-4: config/get carries can_write so the card mirrors may_write."""
    await _setup(hass)
    client = await hass_ws_client(hass)
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    resp = await client.receive_json()
    assert resp["success"]
    assert resp["result"]["can_write"] is True  # hass_ws_client is an admin
    assert "config" in resp["result"] and "rev" in resp["result"]


async def test_files_migrate_copies_and_reports_mapping(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """review CR-2/CR-3: migrate COPIES, never overwrites, and reports the mapping."""
    import os

    from custom_components.houseplan.const import FILES_DIR

    await _setup(hass)
    client = await hass_ws_client(hass)

    base = hass.config.path(FILES_DIR)
    src = os.path.join(base, "old1")
    dst = os.path.join(base, "new1")

    def _prepare() -> None:
        os.makedirs(src, exist_ok=True)
        os.makedirs(dst, exist_ok=True)
        with open(os.path.join(src, "m.pdf"), "wb") as fh:
            fh.write(b"SOURCE")
        # a DIFFERENT file already owns the name in the destination
        with open(os.path.join(dst, "m.pdf"), "wb") as fh:
            fh.write(b"OTHER")

    await hass.async_add_executor_job(_prepare)

    await client.send_json_auto_id(
        {"type": "houseplan/files/migrate", "from_id": "old1", "to_id": "new1"}
    )
    resp = await client.receive_json()
    assert resp["success"], resp
    mapping = resp["result"]["mapping"]
    assert mapping["m.pdf"] != "m.pdf"  # renamed instead of overwriting

    def _read_all() -> tuple[bool, bytes, bytes]:
        with open(os.path.join(dst, "m.pdf"), "rb") as fh:
            other = fh.read()
        with open(os.path.join(dst, mapping["m.pdf"]), "rb") as fh:
            copied = fh.read()
        return os.path.isfile(os.path.join(src, "m.pdf")), other, copied

    src_kept, other, copied = await hass.async_add_executor_job(_read_all)
    assert src_kept, "migrate must COPY, not move (review CR-2)"
    assert other == b"OTHER" and copied == b"SOURCE"

    # cleanup runs only after the config is safely committed, and since v1.46.5
    # reports how many files it removed rather than a bare boolean — it now also
    # keeps anything the stored configuration still references
    await client.send_json_auto_id({"type": "houseplan/files/cleanup", "marker_id": "old1"})
    resp2 = await client.receive_json()
    assert resp2["success"] and resp2["result"]["removed"] >= 1 and resp2["result"]["kept"] == 0
    assert not await hass.async_add_executor_job(lambda: os.path.isdir(src))


async def _cfg(spaces: list[dict]) -> dict:
    """Minimal accepted configuration with the given spaces."""
    return {
        "spaces": [
            {"id": sp["id"], "title": sp["id"], "plan_url": sp.get("plan_url"),
             "aspect": 1.4, "view_box": [0, 0, 1, 1], "rooms": []}
            for sp in spaces
        ],
        "markers": [],
    }


async def _save(client, config, expected_rev):
    await client.send_json_auto_id(
        {"type": "houseplan/config/set", "config": config, "expected_rev": expected_rev}
    )
    return await client.receive_json()


async def _upload(client, space_id, data=b"x", ext="png"):
    import base64 as _b64

    await client.send_json_auto_id({
        "type": "houseplan/plan/set", "space_id": space_id, "ext": ext,
        "data": _b64.b64encode(data).decode(),
    })
    resp = await client.receive_json()
    return resp["result"]["url"], resp["result"]["url"].rsplit("/", 1)[-1]


async def test_plan_upload_does_not_touch_the_previous_file(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """review R2-1: a rejected config write must leave the stored plan intact.

    The upload used to overwrite "<space>.<ext>" (and unlink the other
    extension) BEFORE the revision-checked config write, so a conflict left the
    live plan replaced — or, with a new extension, pointing at a deleted file.
    """
    from pathlib import Path

    from custom_components.houseplan.const import PLANS_DIR

    await _setup(hass)
    client = await hass_ws_client(hass)
    plans = Path(hass.config.path(PLANS_DIR))
    plans.mkdir(parents=True, exist_ok=True)
    for stale in plans.glob("s9.*"):
        stale.unlink()
    legacy = plans / "s9.svg"  # what an older version stored, still referenced
    legacy.write_bytes(b"<svg>old</svg>")

    url0 = "/api/houseplan/content/plans/_/s9.svg"
    resp = await _save(client, await _cfg([{"id": "s9", "plan_url": url0}]), 0)
    rev = resp["result"]["rev"]
    assert legacy.is_file()

    url1, first = await _upload(client, "s9", b"hello")
    # config write rejected (stale revision): nothing on disk may change
    bad = await _save(client, await _cfg([{"id": "s9", "plan_url": url1}]), rev - 1)
    assert not bad["success"] and bad["error"]["code"] == "conflict"
    assert legacy.read_bytes() == b"<svg>old</svg>"
    assert (plans / first).read_bytes() == b"hello"

    # a second attempt neither overwrites the first nor the legacy file
    url2, second = await _upload(client, "s9", b"world")
    assert second != first
    assert (plans / first).read_bytes() == b"hello"
    assert legacy.is_file()

    # config accepted → the superseded file goes, the referenced one stays.
    # `first` is a rejected upload: it is young, so it is kept for now.
    ok = await _save(client, await _cfg([{"id": "s9", "plan_url": url2}]), rev)
    assert ok["success"]
    assert (plans / second).read_bytes() == b"world"
    assert not legacy.exists(), "the superseded plan is collected"
    assert (plans / first).is_file(), "a fresh unreferenced upload is NOT collected"


async def test_late_commit_of_one_client_never_deletes_another_client_s_plan(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """review R3-1: collection belongs to the commit, not to a client's request.

    With the previous `plan/cleanup(keep=...)` command, this interleaving left
    the accepted configuration pointing at a file that had just been deleted:

        A: upload PA, config/set(PA) accepted
        B: upload PB, config/set(PB) accepted
        A: cleanup(keep=PA)  ->  removes PB

    Collection now runs inside config/set under the write lock, so a late
    client cannot express an opinion about a revision it never saw.
    """
    from pathlib import Path

    from custom_components.houseplan.const import PLANS_DIR

    await _setup(hass)
    a = await hass_ws_client(hass)
    b = await hass_ws_client(hass)
    plans = Path(hass.config.path(PLANS_DIR))
    plans.mkdir(parents=True, exist_ok=True)
    for stale in plans.glob("r1.*"):
        stale.unlink()

    url0, p0 = await _upload(a, "r1", b"zero")
    rev = (await _save(a, await _cfg([{"id": "r1", "plan_url": url0}]), 0))["result"]["rev"]

    url_a, pa = await _upload(a, "r1", b"aaa")
    rev_a = (await _save(a, await _cfg([{"id": "r1", "plan_url": url_a}]), rev))["result"]["rev"]
    assert not (plans / p0).exists(), "P0 was superseded by A"

    url_b, pb = await _upload(b, "r1", b"bbb")
    ok = await _save(b, await _cfg([{"id": "r1", "plan_url": url_b}]), rev_a)
    assert ok["success"]

    # the accepted configuration points at PB, and PB is on disk
    assert (plans / pb).read_bytes() == b"bbb"
    assert not (plans / pa).exists(), "PA was superseded by B's commit"


async def test_commit_does_not_collect_another_client_s_uncommitted_upload(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """review R3-1, second interleaving: B uploads, A commits, then B commits.

    A's commit must not remove PB — B has not written its configuration yet, so
    PB is unreferenced but belongs to a live transaction. Age is the guard.
    """
    from pathlib import Path

    from custom_components.houseplan.const import PLANS_DIR

    await _setup(hass)
    a = await hass_ws_client(hass)
    b = await hass_ws_client(hass)
    plans = Path(hass.config.path(PLANS_DIR))
    plans.mkdir(parents=True, exist_ok=True)
    for stale in plans.glob("r2.*"):
        stale.unlink()

    url0, _p0 = await _upload(a, "r2", b"zero")
    rev = (await _save(a, await _cfg([{"id": "r2", "plan_url": url0}]), 0))["result"]["rev"]

    _url_b, pb = await _upload(b, "r2", b"bbb")     # B uploads, does not commit
    url_a, pa = await _upload(a, "r2", b"aaa")
    rev_a = (await _save(a, await _cfg([{"id": "r2", "plan_url": url_a}]), rev))["result"]["rev"]
    assert (plans / pb).is_file(), "an uncommitted upload survives someone else's commit"

    # B now commits on top of A's revision — its file is still there
    ok = await _save(b, await _cfg([{"id": "r2", "plan_url": "/api/houseplan/content/plans/_/" + pb}]), rev_a)
    assert ok["success"]
    assert (plans / pb).read_bytes() == b"bbb"
    assert not (plans / pa).exists()


async def test_a_rejected_upload_is_kept_not_aged_out(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """v1.46.6: age is never a reason to delete a plan file.

    It used to be, for "a file of a space that has a plan and never was one" —
    an upload whose save had failed. That raced the retry: the sweep removed the
    file while the next save was committing a reference to it. Keeping it costs
    a few megabytes nobody can lose.
    """
    import os
    import time

    from custom_components.houseplan.const import PLANS_DIR, SCHEDULED_GRACE_S
    from custom_components.houseplan.store import get_data

    await _setup(hass)
    client = await hass_ws_client(hass)
    plans = hass.config.path(PLANS_DIR)

    url0, p0 = await _upload(client, "r3", b"zero")
    rev = (await _save(client, await _cfg([{"id": "r3", "plan_url": url0}]), 0))["result"]["rev"]

    _url, orphan = await _upload(client, "r3", b"never saved")
    old = time.time() - SCHEDULED_GRACE_S * 12
    os.utime(os.path.join(plans, orphan), (old, old))

    # a commit, and the scheduled pass, and any amount of age: it stays
    assert (await _save(client, await _cfg([{"id": "r3", "plan_url": url0}]), rev))["success"]
    data = get_data(hass)
    await data.sweep()
    await hass.async_block_till_done()

    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, orphan))
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, p0))


async def test_collection_ignores_files_that_are_not_plans(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """The plans directory may hold nothing else, but be sure we only take ours."""
    import os
    import time
    from pathlib import Path

    from custom_components.houseplan.const import PLANS_DIR, PLAN_ORPHAN_TTL_S

    await _setup(hass)
    client = await hass_ws_client(hass)
    plans = Path(hass.config.path(PLANS_DIR))
    plans.mkdir(parents=True, exist_ok=True)
    old = time.time() - PLAN_ORPHAN_TTL_S - 60
    for name in ("notes.txt", "deep.name.with.dots.png", "readme"):
        (plans / name).write_bytes(b"x")
        os.utime(plans / name, (old, old))

    rev = (await _save(client, await _cfg([{"id": "r4", "plan_url": None}]), 0))["result"]["rev"]
    assert rev
    assert (plans / "notes.txt").is_file()
    assert (plans / "deep.name.with.dots.png").is_file()
    assert (plans / "readme").is_file()


async def test_a_marker_showing_its_value_can_be_saved(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """issue #3: display='value' was rejected, and one bad marker fails the lot.

    A user could not save the configuration at all after setting any sensor to
    "value instead of an icon" — the editor offered the option, the schema had
    never heard of it.
    """
    await _setup(hass)
    client = await hass_ws_client(hass)

    cfg = await _cfg([{"id": "f1", "plan_url": None}])
    cfg["markers"] = [
        {"id": "sensor.t", "binding": "entity:sensor.t", "display": "value"},
        {"id": "sensor.h", "binding": "entity:sensor.h", "display": "badge"},
    ]
    ok = await _save(client, cfg, 0)
    assert ok["success"], ok.get("error")

    await client.send_json_auto_id({"type": "houseplan/config/get"})
    got = await client.receive_json()
    assert [m["display"] for m in got["result"]["config"]["markers"]] == ["value", "badge"]


async def test_a_failing_collector_does_not_undo_an_accepted_save(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, monkeypatch
) -> None:
    """review R4-1: garbage collection runs behind an already durable write.

    If it raised, the client got an error for a revision the store had already
    accepted — and its retry then failed with `conflict`, because the server had
    moved on. The commit stands and the event fires regardless.
    """
    from custom_components.houseplan import websocket_api as wsapi

    await _setup(hass)
    client = await hass_ws_client(hass)

    events = []
    hass.bus.async_listen("houseplan_config_updated", lambda ev: events.append(ev.data))

    def _boom(*_a, **_k):
        raise OSError("the plans directory is on fire")

    monkeypatch.setattr(wsapi, "collect_plans", _boom)

    cfg = await _cfg([{"id": "r5", "plan_url": None}])
    ok = await _save(client, cfg, 0)
    assert ok["success"], "an accepted revision must be reported as accepted"
    rev = ok["result"]["rev"]

    await hass.async_block_till_done()
    assert events and events[-1]["rev"] == rev, "the update event still fires"

    # the store really holds the new revision, and the reported rev is usable
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    got = await client.receive_json()
    assert got["result"]["rev"] == rev
    assert [sp["id"] for sp in got["result"]["config"]["spaces"]] == ["r5"]

    monkeypatch.undo()
    again = await _save(client, cfg, rev)
    assert again["success"], "the next CAS on the reported revision goes through"


async def test_content_signed_path_opens_without_a_bearer_header(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, hass_client_no_auth
) -> None:
    """B1 follow-up: a browser <image>/<a> sends no Authorization header.

    The unsigned url must be refused and the signed one must work — otherwise
    plan backgrounds and PDF links 401 on a real dashboard (reproduced live,
    2026-07-27).
    """
    import os

    from custom_components.houseplan.const import CONTENT_URL, PLANS_DIR

    await _setup(hass)
    plans = hass.config.path(PLANS_DIR)

    def _write() -> None:
        os.makedirs(plans, exist_ok=True)
        with open(os.path.join(plans, "s1.png"), "wb") as fh:
            fh.write(b"PNGDATA")

    await hass.async_add_executor_job(_write)
    path = f"{CONTENT_URL}/plans/_/s1.png"

    client = await hass_ws_client(hass)
    await client.send_json_auto_id({"type": "houseplan/content/sign", "paths": [path]})
    resp = await client.receive_json()
    assert resp["success"], resp
    signed = resp["result"]["urls"][path]
    assert "authSig=" in signed

    http = await hass_client_no_auth()
    assert (await http.get(path)).status == 401          # unsigned: refused
    ok = await http.get(signed)
    assert ok.status == 200 and await ok.read() == b"PNGDATA"

    # only our own endpoint may be signed
    await client.send_json_auto_id(
        {"type": "houseplan/content/sign", "paths": ["/api/other/secret"]}
    )
    resp2 = await client.receive_json()
    assert resp2["success"] and resp2["result"]["urls"] == {}


async def test_signing_one_path_may_fail_without_failing_the_request(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, monkeypatch
) -> None:
    """review R5-1: pin the contract the card now codes against.

    One unsignable path must NOT fail the whole call — a single bad url would
    otherwise block the signatures of every other file in the batch. The answer
    is a partial map, and the card treats a path missing from it as a failure
    for that path (backing off) rather than as success.
    """
    from custom_components.houseplan import websocket_api as wsapi
    from custom_components.houseplan.const import CONTENT_URL

    await _setup(hass)
    good = f"{CONTENT_URL}/plans/_/good.png"
    bad = f"{CONTENT_URL}/plans/_/bad.png"

    real = wsapi.async_sign_path if hasattr(wsapi, "async_sign_path") else None
    assert real is None  # imported inside the handler, so patch the source module

    import homeassistant.components.http.auth as ha_auth

    original = ha_auth.async_sign_path

    def _sign(hass_, *args, **kwargs):
        path = next((a for a in args if isinstance(a, str) and a.startswith("/")), "")
        if path == bad:
            raise ValueError("cannot sign this one")
        return original(hass_, *args, **kwargs)

    monkeypatch.setattr(ha_auth, "async_sign_path", _sign)

    client = await hass_ws_client(hass)
    await client.send_json_auto_id({"type": "houseplan/content/sign", "paths": [good, bad]})
    resp = await client.receive_json()
    assert resp["success"], "one bad path must not fail the batch"
    urls = resp["result"]["urls"]
    assert good in urls and "authSig=" in urls[good]
    assert bad not in urls, "an unsignable path is absent, never an unsigned url"


async def test_config_write_is_capped_by_total_size(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1454-05: per-field limits bound each list, this bounds their product."""
    from custom_components.houseplan.validation import MAX_CONFIG_BYTES, MAX_TEXT

    await _setup(hass)
    client = await hass_ws_client(hass)
    cfg = await _cfg([{"id": "f1", "plan_url": None}])
    # every field inside the caps, the whole thing far past them
    blob = "d" * MAX_TEXT
    cfg["settings"] = {"known_devices": [blob] * (MAX_CONFIG_BYTES // MAX_TEXT + 100)}
    resp = await _save(client, cfg, 0)
    assert not resp["success"] and resp["error"]["code"] == "too_large"

    cfg["settings"] = {"known_devices": ["ok"]}
    assert (await _save(client, cfg, 0))["success"]


async def test_layout_keeps_its_revision_and_announces_changes(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1454-08: point-wise writes used to drop the revision and say nothing.

    layout/set offered optimistic locking, but every drag wrote {"layout": …}
    and reset the counter to 0, so the lock protected nothing; and a static card
    on the same dashboard never learned that a marker had moved.
    """
    await _setup(hass)
    client = await hass_ws_client(hass)
    events: list[dict] = []
    hass.bus.async_listen("houseplan_layout_updated", lambda ev: events.append(ev.data))

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    assert (await client.receive_json())["result"]["rev"] == 0

    await client.send_json_auto_id(
        {"type": "houseplan/layout/set", "layout": {"a": {"x": 1, "y": 2}}, "expected_rev": 0}
    )
    rev = (await client.receive_json())["result"]["rev"]
    assert rev == 1

    await client.send_json_auto_id(
        {"type": "houseplan/layout/update", "device_id": "b", "pos": {"x": 3, "y": 4}}
    )
    assert (await client.receive_json())["result"]["rev"] == 2

    await client.send_json_auto_id({"type": "houseplan/layout/delete", "device_id": "b"})
    assert (await client.receive_json())["result"]["rev"] == 3

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    got = await client.receive_json()
    assert got["result"]["rev"] == 3 and got["result"]["layout"] == {"a": {"x": 1, "y": 2}}

    # a stale wholesale write is refused, which it could not be before
    await client.send_json_auto_id(
        {"type": "houseplan/layout/set", "layout": {}, "expected_rev": 1}
    )
    bad = await client.receive_json()
    assert not bad["success"] and bad["error"]["code"] == "conflict"

    await hass.async_block_till_done()
    # the bus does not promise ordering between separately fired events
    assert sorted(e["rev"] for e in events) == [1, 2, 3]


async def test_uploaded_svg_is_sandboxed_and_a_pdf_is_not(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, hass_client
) -> None:
    """HP-1454-01: user SVG served from HA's origin must not be a live document.

    Only SVG gets the header: a CSP on a PDF response can break the browser's
    built-in viewer, and a raster image cannot execute anything anyway.
    """
    import os

    from custom_components.houseplan.const import CONTENT_URL, FILES_DIR, PLANS_DIR

    await _setup(hass)
    plans = hass.config.path(PLANS_DIR)
    files = os.path.join(hass.config.path(FILES_DIR), "m1")

    def _write() -> None:
        os.makedirs(plans, exist_ok=True)
        os.makedirs(files, exist_ok=True)
        with open(os.path.join(plans, "x.svg"), "wb") as fh:
            fh.write(b"<svg xmlns='http://www.w3.org/2000/svg'/>")
        with open(os.path.join(plans, "x.png"), "wb") as fh:
            fh.write(b"PNG")
        with open(os.path.join(files, "m.pdf"), "wb") as fh:
            fh.write(b"%PDF-1.4")

    await hass.async_add_executor_job(_write)
    http = await hass_client()

    svg = await http.get(f"{CONTENT_URL}/plans/_/x.svg")
    assert svg.status == 200
    csp = svg.headers.get("Content-Security-Policy", "")
    assert "sandbox" in csp and "script-src 'none'" in csp
    assert svg.headers["Content-Type"].startswith("image/svg+xml")

    png = await http.get(f"{CONTENT_URL}/plans/_/x.png")
    assert png.status == 200 and "Content-Security-Policy" not in png.headers

    pdf = await http.get(f"{CONTENT_URL}/files/m1/m.pdf")
    assert pdf.status == 200 and "Content-Security-Policy" not in pdf.headers
    assert await pdf.read() == b"%PDF-1.4"


async def test_upload_never_overwrites_an_existing_attachment(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, hass_client
) -> None:
    """HP-1454-02: an upload is not part of the config transaction.

    Writing straight to `<marker>/<filename>` meant a cancelled dialog — or a
    rejected save — left the stored url serving the new bytes. And two new
    markers both uploading `manual.pdf` shared one physical file.
    """
    import os
    import uuid

    from custom_components.houseplan.const import CONTENT_URL, FILES_DIR

    await _setup(hass)
    http = await hass_client()
    # Unique per run: the HA test config dir is shared across the module, so a
    # fixed marker id accumulates files across retries and poisons the assert.
    marker_id = f"m9_{uuid.uuid4().hex[:8]}"

    async def upload(name: str, data: bytes) -> str:
        import aiohttp

        writer = aiohttp.FormData()
        writer.add_field("marker_id", marker_id)
        writer.add_field("file", data, filename=name)
        resp = await http.post("/api/houseplan/upload", data=writer)
        assert resp.status == 200, await resp.text()
        return (await resp.json())["url"]

    first = await upload("manual.pdf", b"ONE")
    second = await upload("manual.pdf", b"TWO")
    assert first != second, "the second upload must not take the first name"

    folder = os.path.join(hass.config.path(FILES_DIR), marker_id)
    names = sorted(
        n for n in await hass.async_add_executor_job(os.listdir, folder) if n.startswith("manual")
    )
    assert names == ["manual-2.pdf", "manual.pdf"]

    got = await http.get(first.replace(CONTENT_URL, CONTENT_URL))
    assert await got.read() == b"ONE", "the first file is untouched"
    got2 = await http.get(second)
    assert await got2.read() == b"TWO"


async def test_upload_leaves_no_temporary_behind(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, hass_client, monkeypatch
) -> None:
    """HP-1460-02: every exit path must take its temporary file with it.

    The streaming rewrite kept one `tmp_path` and cleaned it in an
    `except Exception`, which cancellation (a BaseException) walks straight
    past — and the attachment collector only ever looks inside marker folders,
    so a stranded `.upload-*` was never seen again.
    """
    import os

    from custom_components.houseplan import http_api
    from custom_components.houseplan.const import FILES_DIR
    from custom_components.houseplan.plans import TMP_PREFIX

    await _setup(hass)
    http = await hass_client()
    root = hass.config.path(FILES_DIR)

    def temps() -> list[str]:
        return [n for n in os.listdir(root) if n.startswith(TMP_PREFIX)]

    import aiohttp

    def form(*files, marker="m8"):
        w = aiohttp.FormData()
        w.add_field("marker_id", marker)
        for name, data in files:
            w.add_field("file", data, filename=name)
        return w

    # two file parts: refused, and nothing left over
    resp = await http.post("/api/houseplan/upload", data=form(("a.pdf", b"A"), ("b.pdf", b"B")))
    assert resp.status == 400 and (await resp.json())["error"] == "one_file_only"
    assert temps() == []

    # a rejected extension after the temporary already exists
    resp = await http.post("/api/houseplan/upload", data=form(("evil.exe", b"X")))
    assert resp.status == 400
    assert temps() == []

    # promotion itself blows up
    real = http_api.reserve_filename

    def _boom(*_a, **_k):
        raise OSError("disk on fire")

    monkeypatch.setattr(http_api, "reserve_filename", _boom)
    resp = await http.post("/api/houseplan/upload", data=form(("c.pdf", b"C")))
    assert resp.status == 500
    assert temps() == [], "a failed promotion must not strand the upload"
    monkeypatch.setattr(http_api, "reserve_filename", real)

    # and the happy path leaves nothing either
    resp = await http.post("/api/houseplan/upload", data=form(("d.pdf", b"D")))
    assert resp.status == 200
    assert temps() == []


async def test_repair_issue_goes_when_its_space_does(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1454-09: the cleanup used to walk only spaces that still exist.

    So deleting or renaming a space with a missing plan left its warning in
    Repairs with nothing able to clear it.
    """
    from homeassistant.helpers import issue_registry as ir

    from custom_components.houseplan.const import DOMAIN as HP_DOMAIN

    await _setup(hass)
    client = await hass_ws_client(hass)
    registry = ir.async_get(hass)

    # A reference can only go bad AFTER it is stored — config/set refuses a new
    # one that is already broken (HP-1470-02). So: attach a real plan, then let
    # the file disappear the way it does in life, from outside Home Assistant.
    import os

    from custom_components.houseplan.const import PLANS_DIR

    url, name = await _upload(client, "r7", b"PLAN")
    rev = (await _save(client, await _cfg([{"id": "r7", "plan_url": url}]), 0))["result"]["rev"]
    await hass.async_block_till_done()
    assert registry.async_get_issue(HP_DOMAIN, "broken_plan_r7") is None, "the file is there"

    await hass.async_add_executor_job(
        os.remove, os.path.join(hass.config.path(PLANS_DIR), name)
    )
    rev = (await _save(client, await _cfg([{"id": "r7", "plan_url": url}]), rev))["result"]["rev"]
    await hass.async_block_till_done()
    assert registry.async_get_issue(HP_DOMAIN, "broken_plan_r7") is not None

    # the space is deleted entirely — the warning must not outlive it
    await _save(client, await _cfg([{"id": "other", "plan_url": None}]), rev)
    await hass.async_block_till_done()
    assert registry.async_get_issue(HP_DOMAIN, "broken_plan_r7") is None


async def test_cancelling_an_upload_takes_its_temporary_with_it(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1460-02, properly this time: cancellation, not an ordinary error.

    `asyncio.CancelledError` is a BaseException, so the old `except Exception`
    never saw it and an aborted transfer stranded its `.upload-*`. The previous
    test claimed to cover this and did not — it only exercised error paths.
    """
    import asyncio
    import os

    from custom_components.houseplan.const import FILES_DIR
    from custom_components.houseplan.http_api import HouseplanUploadView
    from custom_components.houseplan.plans import TMP_PREFIX

    entry = await _setup(hass)
    root = hass.config.path(FILES_DIR)
    os.makedirs(root, exist_ok=True)

    started = asyncio.Event()

    class _Part:
        name = "file"
        filename = "big.pdf"

        async def read_chunk(self, _size):
            started.set()
            await asyncio.sleep(3600)  # the client stopped sending; we wait

    class _Reader:
        def __aiter__(self):
            return self

        async def __anext__(self):
            if getattr(self, "_done", False):
                raise StopAsyncIteration
            self._done = True
            return _Part()

    from custom_components.houseplan import http_api as hp_http

    class _User:
        is_admin = True

    class _Request:
        app = {hp_http.KEY_HASS: hass}

        def get(self, _key, default=None):
            return _User()

        async def multipart(self):
            return _Reader()

    task = hass.async_create_task(HouseplanUploadView().post(_Request()))
    await started.wait()
    await asyncio.sleep(0)
    assert [n for n in os.listdir(root) if n.startswith(TMP_PREFIX)], "temp exists mid-upload"

    task.cancel()
    with pytest.raises(asyncio.CancelledError):
        await task
    await hass.async_block_till_done()

    assert [n for n in os.listdir(root) if n.startswith(TMP_PREFIX)] == [], (
        "a cancelled upload must not leave its temporary behind"
    )
    assert entry


async def _seed_aged(hass, names) -> None:
    """Create the given files and backdate them past the orphan TTL."""
    import os
    import time

    from custom_components.houseplan.const import SCHEDULED_GRACE_S

    old = time.time() - SCHEDULED_GRACE_S - 60  # past every grace

    def _do() -> None:
        for path in names:
            os.makedirs(os.path.dirname(path), exist_ok=True)
            with open(path, "wb") as fh:
                fh.write(b"x")
            os.utime(path, (old, old))

    await hass.async_add_executor_job(_do)


def _paths(hass):
    import os

    from custom_components.houseplan.const import FILES_DIR, PLANS_DIR

    files = hass.config.path(FILES_DIR)
    plans = hass.config.path(PLANS_DIR)
    return files, plans, {
        "kept_file": os.path.join(files, "m5", "kept.pdf"),
        "kept_plan": os.path.join(plans, "s5.tok.png"),
        "orphan_file": os.path.join(files, "up_cancelled", "manual.pdf"),
        # a plan file is never collected by age any more; keep one around and
        # assert exactly that
        "kept_reject": os.path.join(plans, "s5.reject.png"),
    }


async def _referenced_config() -> dict:
    cfg = await _cfg([{"id": "s5", "plan_url": "/api/houseplan/content/plans/_/s5.tok.png"}])
    cfg["markers"] = [
        {"id": "m5", "binding": "virtual",
         "pdfs": [{"name": "k", "url": "/api/houseplan/content/files/m5/kept.pdf"}]}
    ]
    return cfg


async def _assert_swept(hass, p) -> None:
    import os

    assert await hass.async_add_executor_job(os.path.isfile, p["kept_file"]), "referenced file kept"
    assert await hass.async_add_executor_job(os.path.isfile, p["kept_plan"]), "referenced plan kept"
    assert not await hass.async_add_executor_job(os.path.isfile, p["orphan_file"]), (
        "a staging folder from a dialog nobody saved is the one thing age collects"
    )
    assert await hass.async_add_executor_job(os.path.isfile, p["kept_reject"]), (
        "a plan file is never removed for being old"
    )


async def test_startup_sweep_collects_what_no_commit_will(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1461-01 / HP-1462-01: collection must not depend on a future save.

    The files are seeded AFTER the configuration is stored. The previous version
    of this test seeded them before, and `config/set` collects too — so it
    passed without the startup pass doing anything, hiding HP-1462-01: during
    setup the entry is not "loaded" yet, so looking its runtime data up by
    domain returned None and the pass degraded to removing streaming
    temporaries only.
    """
    import os

    await _setup(hass)
    client = await hass_ws_client(hass)
    files, _plans, p = _paths(hass)
    # the plan it names has to exist: config/set refuses a NEW broken
    # reference (HP-1470-02). The orphans still arrive after the save.
    await _seed_aged(hass, [p["kept_plan"]])
    assert (await _save(client, await _referenced_config(), 0))["success"]

    await _seed_aged(hass, list(p.values()))

    entry = hass.config_entries.async_entries(DOMAIN)[0]
    assert await hass.config_entries.async_reload(entry.entry_id)
    await hass.async_block_till_done()

    await _assert_swept(hass, p)
    assert not await hass.async_add_executor_job(
        os.path.isdir, os.path.join(files, "up_cancelled")
    ), "the emptied staging folder goes with its last file"


async def test_periodic_sweep_collects_too(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """The scheduled pass, invoked directly rather than by faking a 24 h jump.

    Firing a time change proves the timer fires; awaiting the callback proves it
    does the work. This asserts the second, which is the part that regressed.
    """
    from custom_components.houseplan.store import get_data

    await _setup(hass)
    client = await hass_ws_client(hass)
    _files, _plans, p = _paths(hass)
    # the plan it names has to exist: config/set refuses a NEW broken
    # reference (HP-1470-02). The orphans still arrive after the save.
    await _seed_aged(hass, [p["kept_plan"]])
    assert (await _save(client, await _referenced_config(), 0))["success"]

    await _seed_aged(hass, list(p.values()))

    data = get_data(hass)
    assert data is not None and data.sweep is not None, "setup must publish the sweep"
    await data.sweep()
    await hass.async_block_till_done()

    await _assert_swept(hass, p)


async def test_sweep_and_a_config_write_do_not_race(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """Both take the same write lock, so an accepted config cannot lose a file.

    Without it the sweep could decide a file is unreferenced, a commit could
    start referencing it, and the file would go — leaving the accepted revision
    pointing at nothing.
    """
    import asyncio
    import os

    await _setup(hass)
    client = await hass_ws_client(hass)
    _files, plans, p = _paths(hass)
    # the plan it names has to exist: config/set refuses a NEW broken
    # reference (HP-1470-02). The orphans still arrive after the save.
    await _seed_aged(hass, [p["kept_plan"]])
    rev = (await _save(client, await _referenced_config(), 0))["result"]["rev"]

    # an aged, currently unreferenced plan that the commit below adopts
    newcomer = os.path.join(plans, "s5.newcomer.png")
    await _seed_aged(hass, [p["kept_file"], p["kept_plan"], newcomer])

    cfg2 = await _referenced_config()
    cfg2["spaces"][0]["plan_url"] = "/api/houseplan/content/plans/_/s5.newcomer.png"

    # Drive the sweep directly rather than through a reload: an entry reload has
    # an unload window in which any WS call legitimately answers `not_ready`, so
    # a save racing THAT proves nothing about the lock and fails at random.
    from custom_components.houseplan.store import get_data

    data = get_data(hass)
    assert data is not None and data.sweep is not None
    _swept, saved = await asyncio.gather(data.sweep(), _save(client, cfg2, rev))
    await hass.async_block_till_done()

    # assert the CONCRETE outcome: a save that came back `not_ready` would leave
    # the old config pointing at the old file and satisfy a vaguer check
    assert saved["success"], saved.get("error")
    await client.send_json_auto_id({"type": "houseplan/config/get"})
    stored = (await client.receive_json())["result"]["config"]
    assert stored["spaces"][0]["plan_url"].endswith("s5.newcomer.png")
    assert await hass.async_add_executor_job(
        os.path.isfile, os.path.join(plans, "s5.newcomer.png")
    ), "the file the accepted config points at must exist"


async def test_files_cleanup_keeps_referenced_files(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """v1.46.5: the client may say what it no longer needs, never what may go.

    `files/cleanup` used to rmtree the folder it was handed. A partial migration
    leaves some urls pointing into that folder — the copy deliberately does not
    rewrite the ones it could not confirm — so those were live links to files
    being deleted. A wrong id from any client had the same effect on a device's
    manuals.
    """
    import os

    from custom_components.houseplan.const import FILES_DIR

    await _setup(hass)
    client = await hass_ws_client(hass)
    folder = os.path.join(hass.config.path(FILES_DIR), "m7")

    def _seed() -> None:
        os.makedirs(folder, exist_ok=True)
        for n in ("kept.pdf", "orphan.pdf"):
            with open(os.path.join(folder, n), "wb") as fh:
                fh.write(b"x")

    await hass.async_add_executor_job(_seed)

    cfg = await _cfg([{"id": "s7", "plan_url": None}])
    cfg["markers"] = [
        {"id": "other", "binding": "virtual",
         "pdfs": [{"name": "k", "url": "/api/houseplan/content/files/m7/kept.pdf"}]}
    ]
    assert (await _save(client, cfg, 0))["success"]

    await client.send_json_auto_id({"type": "houseplan/files/cleanup", "marker_id": "m7"})
    resp = await client.receive_json()
    assert resp["success"] and resp["result"] == {"ok": True, "removed": 1, "kept": 1}

    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(folder, "kept.pdf")), (
        "a file the configuration still references survives a cleanup of its folder"
    )
    assert not await hass.async_add_executor_job(os.path.isfile, os.path.join(folder, "orphan.pdf"))


async def test_detaching_a_plan_keeps_the_file(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1465-01, through the real save — where the earlier tests never looked.

    Every check for this lived in the pure collector with old and new config
    equal, i.e. the scheduled pass. The transition that matters is a save, and
    there the file was deleted the moment the reference was cleared.
    """
    import os

    from custom_components.houseplan.const import PLANS_DIR

    await _setup(hass)
    client = await hass_ws_client(hass)
    plans = hass.config.path(PLANS_DIR)

    url, name = await _upload(client, "d1", b"PLAN", ext="png")
    rev = (await _save(client, await _cfg([{"id": "d1", "plan_url": url}]), 0))["result"]["rev"]
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name))

    # detach: the space stays, its plan does not
    rev = (await _save(client, await _cfg([{"id": "d1", "plan_url": None}]), rev))["result"]["rev"]
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name)), (
        "the editor says the image stays on disk — it has to actually stay"
    )

    # a restart does not change its mind either
    entry = hass.config_entries.async_entries(DOMAIN)[0]
    assert await hass.config_entries.async_reload(entry.entry_id)
    await hass.async_block_till_done()
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name))

    # re-attach, then replace: THAT removes the one it replaced
    rev = (await _save(client, await _cfg([{"id": "d1", "plan_url": url}]), rev))["result"]["rev"]
    url2, name2 = await _upload(client, "d1", b"NEWPLAN", ext="png")
    rev = (await _save(client, await _cfg([{"id": "d1", "plan_url": url2}]), rev))["result"]["rev"]
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name2))
    assert not await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name))

    # and deleting the space keeps its plan
    await _save(client, await _cfg([]), rev)
    await hass.async_block_till_done()
    assert await hass.async_add_executor_job(os.path.isfile, os.path.join(plans, name2))


async def test_stored_plans_can_be_listed_and_deleted_on_request(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1466-01/-02: "we never delete" needs the files to be findable.

    A detached plan stays on disk. Without a way to see it, that is neither a
    recovery path nor a disk policy — it is just accumulation. Listing gives
    both: the user attaches it again, or deletes it on purpose, which is the
    only way a plan file is ever removed.
    """
    await _setup(hass)
    client = await hass_ws_client(hass)

    used_url, used = await _upload(client, "p1", b"USED", ext="png")
    _free_url, free = await _upload(client, "p2", b"FREE", ext="png")
    rev = (await _save(client, await _cfg([{"id": "p1", "plan_url": used_url}]), 0))["result"]["rev"]

    await client.send_json_auto_id({"type": "houseplan/plans/list"})
    # the HA test config dir is shared across the module: look at ours, not all
    plans = {p["name"]: p for p in (await client.receive_json())["result"]["plans"]}
    assert {used, free} <= set(plans)
    assert plans[used]["used_by"] and not plans[free]["used_by"]
    assert plans[used]["size"] == 4 and plans[free]["url"].endswith(free)

    # a plan a space still uses is refused — the config decides, not the client
    await client.send_json_auto_id({"type": "houseplan/plans/delete", "name": used})
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "in_use"

    # an unused one goes on request
    await client.send_json_auto_id({"type": "houseplan/plans/delete", "name": free})
    assert (await client.receive_json())["result"]["removed"] is True

    # detach the other, and now it is deletable — and listed as free until then
    await _save(client, await _cfg([{"id": "p1", "plan_url": None}]), rev)
    await client.send_json_auto_id({"type": "houseplan/plans/list"})
    plans = {p["name"]: p for p in (await client.receive_json())["result"]["plans"]}
    assert used in plans, "the detached plan is still there, ready to re-attach"
    assert not plans[used]["used_by"]
    assert free not in plans, "and the one we deleted is gone"

    # nothing outside the plans folder can be reached through the name
    await client.send_json_auto_id(
        {"type": "houseplan/plans/delete", "name": "../../configuration.yaml"}
    )
    bad = await client.receive_json()
    assert not bad["success"] and bad["error"]["code"] == "invalid_name"


async def test_config_set_refuses_a_plan_that_no_longer_exists(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1470-02: a stored internal plan url must name a file that exists.

    The card can pick a plan and delete it from the same dialog, and two clients
    can do the same in either order. The lock serialises them; it says nothing
    about whether the file survived, so the check has to be here.
    """
    await _setup(hass)
    client = await hass_ws_client(hass)

    url, name = await _upload(client, "x1", b"PLAN", ext="png")
    await client.send_json_auto_id({"type": "houseplan/plans/delete", "name": name})
    assert (await client.receive_json())["result"]["removed"] is True

    resp = await _save(client, await _cfg([{"id": "x1", "plan_url": url}]), 0)
    assert not resp["success"] and resp["error"]["code"] == "missing_plan"

    # an external or legacy url is the user's business, not ours to verify
    assert (await _save(client, await _cfg([{"id": "x1", "plan_url": "/local/mine.png"}]), 0))["success"]


async def test_uploads_are_bounded_by_a_store_quota(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, monkeypatch
) -> None:
    """HP-1470-01: nothing is deleted for being old, so growth stops at the door."""
    from custom_components.houseplan import websocket_api as wsapi

    from pathlib import Path

    from custom_components.houseplan.const import PLANS_DIR
    from custom_components.houseplan.plans import dir_usage

    await _setup(hass)
    client = await hass_ws_client(hass)
    # every test in this module shares one config directory, so the plans folder
    # is not empty here — budget two more from whatever is already stored
    stored, _b = await hass.async_add_executor_job(
        lambda: dir_usage(Path(hass.config.path(PLANS_DIR)))[::-1]
    )
    monkeypatch.setattr(wsapi, "MAX_PLANS_FILES", stored + 2)

    await _upload(client, "q1", b"one")
    await _upload(client, "q1", b"two")

    import base64

    await client.send_json_auto_id({
        "type": "houseplan/plan/set", "space_id": "q1", "ext": "png",
        "data": base64.b64encode(b"three").decode(),
    })
    resp = await client.receive_json()
    assert not resp["success"] and resp["error"]["code"] == "too_many_files"


async def test_parallel_uploads_cannot_slip_past_the_quota_together(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator, monkeypatch
) -> None:
    """HP-1490-02: N uploads used to measure the store before any of them
    wrote, so all N passed a quota only one of them fits under. The
    check→write pair is one job under upload_lock now, so whatever the
    interleaving, at most ONE of two competing uploads can take the last slot.
    """
    import asyncio
    import base64

    from custom_components.houseplan import websocket_api as wsapi
    from custom_components.houseplan.const import PLANS_DIR
    from custom_components.houseplan.plans import dir_usage
    from pathlib import Path

    await _setup(hass)
    c1 = await hass_ws_client(hass)
    c2 = await hass_ws_client(hass)
    _bytes, stored = await hass.async_add_executor_job(
        dir_usage, Path(hass.config.path(PLANS_DIR))
    )
    monkeypatch.setattr(wsapi, "MAX_PLANS_FILES", stored + 1)  # room for ONE

    payload = base64.b64encode(b"PLAN").decode()

    async def upload(client, sid):
        await client.send_json_auto_id({
            "type": "houseplan/plan/set", "space_id": sid, "ext": "png", "data": payload,
        })
        return await client.receive_json()

    r1, r2 = await asyncio.gather(upload(c1, "pa"), upload(c2, "pb"))
    oks = [r for r in (r1, r2) if r["success"]]
    errs = [r for r in (r1, r2) if not r["success"]]
    assert len(oks) == 1, "exactly one takes the last slot"
    assert errs and errs[0]["error"]["code"] == "too_many_files"
    _bytes2, after = await hass.async_add_executor_job(
        dir_usage, Path(hass.config.path(PLANS_DIR))
    )
    assert after == stored + 1, "the store holds what the quota promised, not more"


async def test_layout_coordinates_are_bounded(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1500-03: any finite float used to pass, and one stored 1e100
    stretched every client's frame until the plan was invisible. Positions are
    normalised to the canvas; +-4 is generous slack for an icon dragged past an
    edge, not an envelope for absurdity."""
    await _setup(hass)
    client = await hass_ws_client(hass)

    await client.send_json_auto_id({
        "type": "houseplan/layout/update", "device_id": "d1",
        "pos": {"s": "f1", "x": 1e100, "y": 0.5},
    })
    resp = await client.receive_json()
    assert not resp["success"], "an absurd coordinate is refused at the door"

    await client.send_json_auto_id({
        "type": "houseplan/layout/update", "device_id": "d1",
        "pos": {"s": "f1", "x": -1.2, "y": 0.5},
    })
    resp = await client.receive_json()
    assert resp["success"], "a bit past the edge is a dragged icon, not an attack"


async def test_geometry_repair_is_explicit_previewable_and_undoable(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1500-01: an install that crashed in the v1.48 migration window has a
    square config and an old-coordinates layout, and NOTHING left to tell —
    both triggers went with the write that succeeded. No automation can fix
    that safely (a correct layout looks the same), so the repair is a person
    saying "this space, this old aspect": preview first, one-deep backup with
    the write, undo restores it."""
    await _setup(hass)
    client = await hass_ws_client(hass)

    # the stranded state: nothing in the layout says it is old
    await client.send_json_auto_id({
        "type": "houseplan/layout/set",
        "layout": {"lamp": {"s": "wide", "x": 0.2, "y": 0.1},
                   "other": {"s": "elsewhere", "x": 0.9, "y": 0.9}},
    })
    assert (await client.receive_json())["success"]
    # Unknown/new service metadata must survive every layout writer. This is
    # the mutation guard against restoring geometry/repair's old allow-list
    # payload, which silently erased import/optimizer state (#50/R4, #87).
    from custom_components.houseplan.store import get_data

    runtime = get_data(hass)
    stored = await runtime.store.async_load()
    stored["future_metadata"] = {"must": "survive-repair"}
    await runtime.store.async_save(stored)

    # preview does not touch the store
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wide", "aspect": 2.0, "dry_run": True,
    })
    dry = (await client.receive_json())["result"]
    assert dry["moved"] == 1 and dry["after"]["lamp"]["y"] == 0.3
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    assert (await client.receive_json())["result"]["layout"]["lamp"]["y"] == 0.1

    # the repair itself
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wide", "aspect": 2.0,
    })
    res = (await client.receive_json())["result"]
    assert res["moved"] == 1
    repaired_store = await runtime.store.async_load()
    assert repaired_store["future_metadata"] == {"must": "survive-repair"}
    assert repaired_store["repair_backup"]["space"] == "wide"
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    lay = (await client.receive_json())["result"]["layout"]
    assert lay["lamp"] == {"s": "wide", "x": 0.2, "y": 0.3}
    assert lay["other"] == {"s": "elsewhere", "x": 0.9, "y": 0.9}, "another space untouched"

    # a routine drag must not eat the backup...
    await client.send_json_auto_id({
        "type": "houseplan/layout/update", "device_id": "other",
        "pos": {"s": "elsewhere", "x": 0.5, "y": 0.5},
    })
    assert (await client.receive_json())["success"]

    # ...because undo is the safety net for repairing the WRONG space
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wide", "aspect": 2.0, "undo": True,
    })
    res = (await client.receive_json())["result"]
    assert res["restored"] == 1
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    lay = (await client.receive_json())["result"]["layout"]
    assert lay["lamp"] == {"s": "wide", "x": 0.2, "y": 0.1}, "back to before the repair"
    assert lay["other"]["x"] == 0.5, "the drag after the repair survives the undo"

    # undo without a backup for that space is a clean error
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "nosuch", "aspect": 2.0, "undo": True,
    })
    bad = await client.receive_json()
    assert not bad["success"] and bad["error"]["code"] == "no_backup"


async def test_a_noop_repair_does_not_eat_the_backup(
    hass: HomeAssistant, hass_ws_client: WebSocketGenerator
) -> None:
    """HP-1501-02: a repair that matches nothing used to answer moved: 0 and
    replace the one-deep backup with an empty one — a typo after a wrong
    repair destroyed the only way back. Now it is an error, the revision does
    not move, and the previous repair is still undoable."""
    await _setup(hass)
    client = await hass_ws_client(hass)

    await client.send_json_auto_id({
        "type": "houseplan/layout/set",
        "layout": {"lamp": {"s": "wide", "x": 0.2, "y": 0.1}},
    })
    assert (await client.receive_json())["success"]

    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wide", "aspect": 2.0,
    })
    rev = (await client.receive_json())["result"]["rev"]

    # the typo: syntactically valid, matches nothing
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wid", "aspect": 2.0,
    })
    bad = await client.receive_json()
    assert not bad["success"] and bad["error"]["code"] == "nothing_to_repair"

    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    got = (await client.receive_json())["result"]
    assert got["rev"] == rev, "a refused repair moves nothing, including the revision"

    # the wrong-space repair from before the typo is STILL undoable
    await client.send_json_auto_id({
        "type": "houseplan/geometry/repair", "space_id": "wide", "aspect": 2.0, "undo": True,
    })
    res = (await client.receive_json())["result"]
    assert res["restored"] == 1
    await client.send_json_auto_id({"type": "houseplan/layout/get"})
    lay = (await client.receive_json())["result"]["layout"]
    assert lay["lamp"] == {"s": "wide", "x": 0.2, "y": 0.1}