mirror of
https://github.com/Matysh/houseplan-card
synced 2026-10-03 05:08:53 +00:00
Codex
fe3b85c06b
(1) Corner and edge handles carry the same hit radius (1.8 % of the view), so on furniture narrower than 4·hr — a 40 cm cabinet — the two circles overlap and whichever is painted last takes the tap. Edges were painted last. Corners are now, because a side handle scales one axis while a corner scales both, and the object is small exactly when proportional resize matters most. The visible beads are unchanged. The audit called this 'proportional resize becomes unavailable'; the measurement says otherwise and the spec records the correction: the corner centre lies outside the edge circle, so the corner was reachable — its area was halved, not lost. A polish, not a bug, and worth fixing because it is one line of ordering. (2) Alignment guides in the devices mode excluded the dragged marker by _drag, which has been null there since #74 moved device dragging into _deviceDrag. So the marker being moved was among its own candidates. Nothing looked wrong because a point always matches itself within tolerance — the guide was drawn from the marker to itself, visually identical to an honest one, and the smoke asserted only guides() >= 1. The smoke now compares the candidate lists with and without the drag and demands exactly one removed entry. (3) The 38 settings-help strings stay in the initial chunk, and that is now a recorded decision rather than an oversight: measured 2 654 B gzip, 0.9 % of the ceiling, against splitting a synchronous dictionary in two, a second request on first hint, and a second source for the key type derived from en.json (#391). docs/ARCHITECTURE.md says so, with the number that would justify revisiting it. Both mutants run by hand: reverting the paint order reddens the 40 cm probe while the 160 cm one stays green; restoring _drag reddens the guides smoke. User-Visible: yes Issue: #400
82 lines
4.9 KiB
JavaScript
82 lines
4.9 KiB
JavaScript
import { launch, checkAll, finish } from './serve.mjs';
|
|
const { page, browser } = await launch();
|
|
const res = await page.evaluate(async () => {
|
|
const out = {};
|
|
const c = window.__card;
|
|
const sr = () => c.shadowRoot || c.renderRoot;
|
|
const g = c._gridPitch;
|
|
const guides = () => sr().querySelectorAll('.alignline').length;
|
|
// 1) рисование контура: курсор на одном X с вершиной комнаты → гид
|
|
c._setMode('plan'); c._tool = 'draw'; await c.updateComplete;
|
|
const r1 = c._spaceModel().rooms.find((r) => r.id === 'r1');
|
|
const poly = r1.poly || [[r1.x, r1.y], [r1.x + r1.w, r1.y], [r1.x + r1.w, r1.y + r1.h], [r1.x, r1.y + r1.h]];
|
|
const v = poly[0];
|
|
c._path = [[v[0] + g * 10, v[1] + g * 10]];
|
|
c._cursorPt = [v[0], v[1] + g * 20]; // тот же X, что у вершины
|
|
c.requestUpdate(); await c.updateComplete;
|
|
out.drawGuide = guides() >= 1;
|
|
out.dot = sr().querySelectorAll('.aligndot').length >= 1;
|
|
// нет выравнивания → нет гидов
|
|
c._cursorPt = [v[0] + g * 7 + 1.7, v[1] + g * 13 + 2.3]; c.requestUpdate(); await c.updateComplete;
|
|
out.noGuideOffAxis = guides() === 0;
|
|
// 2) бейдж угла: 45° красит
|
|
c._cursorPt = [c._path[0][0] + g * 5, c._path[0][1] + g * 5]; c.requestUpdate(); await c.updateComplete;
|
|
const ml = sr().querySelector('.measurelabel');
|
|
out.badge45 = !!ml && ml.classList.contains('on45') && ml.textContent.includes('45');
|
|
c._cursorPt = [c._path[0][0] + g * 5, c._path[0][1] + g * 2]; c.requestUpdate(); await c.updateComplete;
|
|
const ml2 = sr().querySelector('.measurelabel');
|
|
out.badgeOff45 = !!ml2 && !ml2.classList.contains('on45') && ml2.textContent.includes('°');
|
|
c._path = []; c._cursorPt = null;
|
|
// 3) редактор устройств: drag значка в линию с другим значком
|
|
c._setMode('devices'); await c.updateComplete;
|
|
const devs = c._devices.filter((d) => d.space === c._space);
|
|
const a = devs[0], b = devs[1];
|
|
const pa = c._pos(a);
|
|
// поставим b на тот же Y, начнём drag
|
|
c._layout = { ...c._layout, [b.id]: { s: c._space, x: (pa.x + g * 12) / 1000, y: pa.y / 1000 } };
|
|
const pb = c._pos(b);
|
|
c._deviceDrag = {
|
|
id: b.id, spaceId: b.space, displayName: b.name, pointerId: 74,
|
|
source: null, sx: 0, sy: 0, ox: pb.x, oy: pb.y, moved: true,
|
|
before: { s: b.space, x: pb.x / 1000, y: pb.y / 1000 },
|
|
start: c._devicePlacementForCanvas(b, pb.x, pb.y),
|
|
};
|
|
const keptDrag = c._deviceDrag;
|
|
c.requestUpdate(); await c.updateComplete;
|
|
out.devGuide = guides() >= 1;
|
|
// #400: направляющая обязана идти ОТ ДРУГОГО значка, а не от самого себя.
|
|
// Прежняя проверка `guides() >= 1` этого не различала: точка всегда
|
|
// совпадает сама с собой в пределах допуска, поэтому исключение
|
|
// перетаскиваемого маркера могло не работать вовсе — и не работало,
|
|
// потому что читало `_drag`, который в этом режиме всегда null.
|
|
out.devGuideComesFromAnotherMarker = (() => {
|
|
const key = (list) => list.map((point) => point.join(','));
|
|
const withDrag = key(c._editorRuntime._alignCandidates());
|
|
c._deviceDrag = null;
|
|
const withoutDrag = key(c._editorRuntime._alignCandidates());
|
|
c._deviceDrag = keptDrag;
|
|
// Исключение снимает РОВНО один кандидат — перетаскиваемый маркер.
|
|
// Сравнение по разнице списков, а не по заранее посчитанной точке:
|
|
// позиция значка живёт вместе с перетаскиванием и к моменту проверки
|
|
// уже другая.
|
|
const removed = withoutDrag.filter((point) => !withDrag.includes(point));
|
|
return withDrag.length === withoutDrag.length - 1 && removed.length === 1;
|
|
})();
|
|
c._deviceDrag = null; c.requestUpdate(); await c.updateComplete;
|
|
out.devGuideGone = guides() === 0;
|
|
// 4) подложка: рисование прямоугольника с углом на одном X с углом другой фигуры
|
|
c._setMode('decor'); await c.updateComplete;
|
|
c._curSpaceCfg.decor = [{ id: 'd1', kind: 'rect', x: 0.2, y: 0.2, w: 0.1, h: 0.1, color: '#ff0000', width: 3 }];
|
|
const W = 1000, H = 1000; // square canvas
|
|
c._decorDraft = { kind: 'rect', a: [0.5 * W, 0.5 * H], b: [0.2 * W, 0.6 * H], pid: 9 }; // b.x == углу d1
|
|
c.requestUpdate(); await c.updateComplete;
|
|
out.decorGuide = guides() >= 1;
|
|
c._decorDraft = null; c._curSpaceCfg.decor = []; c.requestUpdate(); await c.updateComplete;
|
|
// 5) в Просмотре гидов не бывает
|
|
c._setMode('view'); await c.updateComplete;
|
|
out.noneInView = guides() === 0;
|
|
return out;
|
|
});
|
|
checkAll(res);
|
|
await finish(browser, res);
|